Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout should not be called if there are coordinates in Extended SMILES #3462

Closed
Zhirnoff opened this issue Oct 18, 2023 · 1 comment · Fixed by #3470, #3488, #3500 or #3504
Closed

Layout should not be called if there are coordinates in Extended SMILES #3462

Zhirnoff opened this issue Oct 18, 2023 · 1 comment · Fixed by #3470, #3488, #3500 or #3504
Assignees
@Nitvex
Labels
Priority: High
Milestone
Ketcher 2.15.0-rc.5

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Oct 18, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Paste CC1CCCC(C)C=1N1C([C@@H](Cl)C)=CC=C1 |a:7,&1:10,r,wD:7.6,10.11,(13.73,-9.95,;14.59,-9.45,;16.07,-8.70,;16.18,-6.82,;17.23,-7.80,;16.33,-9.45,;17.19,-9.95,;15.46,-9.95,;15.46,-10.95,;14.76,-11.67,;13.77,-11.53,;13.40,-10.60,;13.16,-12.32,;15.23,-12.55,;16.22,-12.38,;16.36,-11.39,)|

Actual behavior
Layout is called when Extended SMILES have coordinates

Expected behavior
Layout should not be called if there are coordinates in Extended SMILES

Screenshots
2023-10-18_19h31_39

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.15.0-rc.4

#186288932
@Zhirnoff Zhirnoff added this to the Refined Backlog milestone Oct 18, 2023
Nitvex added a commit that referenced this issue Oct 19, 2023
@Nitvex
#3462 – Layout should not be called if there are coordinates in Exten…
e001696 
…ded SMILES
Nitvex added a commit that referenced this issue Oct 19, 2023
@Nitvex
#3462 – fixed stylelint problems
9347634
@Nitvex Nitvex linked a pull request Oct 19, 2023 that will close this issue
#3462 – layout should not be called if there are coordinates in extended smiles #3470
Merged
9 tasks
Nitvex added a commit that referenced this issue Oct 19, 2023
@Nitvex
#3462 – security issues fix
83fc203
@Zhirnoff
Copy link
Collaborator Author

Pre-tested. Looks like bug is fixed.
2023-10-20_16h13_51
2023-10-20_16h14_53

Nitvex added a commit that referenced this issue Oct 20, 2023
@Nitvex
#3462 – layout should not be called if there are coordinates in exten…
c5eb4c1 
…ded smiles (#3470)

* #3462 – Layout should not be called if there are coordinates in Extended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix
Nitvex added a commit that referenced this issue Oct 20, 2023
@Nitvex
* #3462 – Layout should not be called if there are coordinates in Ext…
4c6af72 
…ended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix
@Nitvex Nitvex mentioned this issue Oct 20, 2023
Closed
9 tasks
@Nitvex Nitvex linked a pull request Oct 20, 2023 that will close this issue
Backmerge: #3462 – Layout should not be called if there are coordinates in Extended SMILES #3479
Closed
9 tasks
@even1024 even1024 mentioned this issue Oct 23, 2023
Closed
Nitvex added a commit that referenced this issue Oct 23, 2023
@Nitvex
#3462 – Layout should not be called if there are coordinates in Exten…
08add98 
…ded SMILES
@Nitvex Nitvex linked a pull request Oct 23, 2023 that will close this issue
#3462 – Layout should not be called if there are coordinates in Extended SMILES #3488
Merged
9 tasks
Nitvex added a commit that referenced this issue Oct 24, 2023
@Nitvex
#3462 – Layout should not be called if there are coordinates in Exten…
6e7f54d 
…ded SMILES (#3488)
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
* #3462 – Layout should not be called if there are coordinates in Ext…
a4ce09f 
…ended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
Backmerge: #3462 – Layout should not be called if there are coordinat…
dc30783 
…es in Extended SMILES
@Nitvex Nitvex linked a pull request Oct 25, 2023 that will close this issue
Backmerge: #3462 – layout should not be called if there are coordinates in extended smiles #3500
Merged
9 tasks
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
Backmerge: #3462 – Layout should not be called if there are coordinat…
7e2783c 
…es in Extended SMILES
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
Backmerge: #3462 – layout should not be called if there are coordinat…
f88f268 
…es in extended smiles (#3500)

* * #3462 – Layout should not be called if there are coordinates in Extended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix

* Backmerge: #3462 – Layout should not be called if there are coordinates in Extended SMILES
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
Backmerge: #3462 – layout should not be called if there are coordinat…
2a4a788 
…es in extended smiles (#3500)

* * #3462 – Layout should not be called if there are coordinates in Extended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix

* Backmerge: #3462 – Layout should not be called if there are coordinates in Extended SMILES
@Nitvex Nitvex linked a pull request Oct 25, 2023 that will close this issue
Backmerge: #3462 – layout should not be called if there are coordinates in extended smiles (#3500) #3504
Merged
9 tasks
Nitvex added a commit that referenced this issue Oct 25, 2023
@Nitvex
Backmerge: #3462 – layout should not be called if there are coordinat…
192476a 
…es in extended smiles (#3500) (#3504)

* * #3462 – Layout should not be called if there are coordinates in Extended SMILES

* #3462 – fixed stylelint problems

* #3462 – security issues fix

* Backmerge: #3462 – Layout should not be called if there are coordinates in Extended SMILES
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.15.0-rc.5
2 participants
@Nitvex @Zhirnoff