Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Change RNA-preset configuration #3475

Closed
olganaz opened this issue Oct 20, 2023 · 1 comment
Closed

Macro: Change RNA-preset configuration #3475

olganaz opened this issue Oct 20, 2023 · 1 comment
Assignees
@chgayane
Labels
feature request
Milestone
Macromolecules Ot...

Comments

@olganaz
Copy link
Collaborator

olganaz commented Oct 20, 2023 •
edited
Loading

Background
Change RNA-preset configuration according to biological rules

Requirements
RNA preset = sugar + phosphate + base

  • R1 of sugar (oriented left) should be connected with R2 (oriented right) of phosphate
  • R3 of sugar (oriented bottom) should be connected with R1 (oriented top) of base
  • R1 of phosphate should be oriented left
  • R2 of sugar should be oriented right

Preset preview which is displayed near the arrow while hovering on canvas (after one of the presets is selected) should be also changed according to mockup

image
@olganaz olganaz self-assigned this Oct 20, 2023
@olganaz olganaz changed the title [Macro] Change RNA-preset layout [Macro] Change RNA-preset orientation Oct 20, 2023
@olganaz olganaz changed the title [Macro] Change RNA-preset orientation [Macro] Change RNA-preset configuration Oct 23, 2023
@chgayane chgayane assigned chgayane and unassigned olganaz Oct 25, 2023
@rrodionov91 rrodionov91 changed the title [Macro] Change RNA-preset configuration Macro: Change RNA-preset configuration Nov 2, 2023
chgayane pushed a commit that referenced this issue Nov 6, 2023
#3475 - correct rna preset configs
b5c13c6
chgayane pushed a commit that referenced this issue Nov 6, 2023
#3475 - correct rna preset configs
8d92d33
chgayane pushed a commit that referenced this issue Nov 6, 2023
#3475 - correct rna preset configs
75e0f4c
@chgayane chgayane linked a pull request Nov 6, 2023 that will close this issue
Macro: #3475 – Change RNA-preset configuration #3541
Merged
9 tasks
chgayane pushed a commit that referenced this issue Nov 8, 2023
#3475 - corrected logic for all types of monomers
0a42c9f
chgayane pushed a commit that referenced this issue Nov 8, 2023
#3475 - fixed style issues
6d4a986
chgayane pushed a commit that referenced this issue Nov 8, 2023
#3475 - correct rna preset configs
0a58350
chgayane pushed a commit that referenced this issue Nov 8, 2023
#3475 - removed env file
e593c8d
chgayane pushed a commit that referenced this issue Nov 8, 2023
#3475 - fixed code styles
46a6ac6
chgayane pushed a commit that referenced this issue Nov 9, 2023
#3475 - updated screenshots
58be80c
@urszula-gawlowska
Copy link
Collaborator

One bug found during testing PR
Steps to reproduce:

  1. Add moen phosphate to the canvas
  2. Add 25R sugar to the canvas
  3. Add eaA base to the canvas
  4. Select single bond
  5. Connect moen phosphate with sugar
  6. Conncet sugar with eaA base
    Expected result:
    Sugar and base should be connected by R3-R1 attachment points
    Actual result:
    Sugar and base is connected by R3-R2 attachment points

moen_25r_eaA

chgayane pushed a commit that referenced this issue Nov 9, 2023
#3475 - fixed Sugar-R3 and Base-R1 connnection
be12d94
chgayane pushed a commit that referenced this issue Nov 9, 2023
#3475 - fixed code styles
c1e7ec8
chgayane pushed a commit that referenced this issue Nov 9, 2023
#3475 - updated screenshots
0970477
chgayane pushed a commit that referenced this issue Nov 9, 2023
#3475 - updated screenshots
3c6dc46
rrodionov91 added a commit that referenced this issue Nov 9, 2023
@chgayane @rrodionov91
Macro: #3475 – Change RNA-preset configuration (#3541)
a1bffc1 
Co-authored-by: Gayane Chilingaryan <gayane_chilingaryan@epam.com>
Co-authored-by: Roman Rodionov <rrodionov91@mail.ru>
@rrodionov91 rrodionov91 reopened this Nov 10, 2023
@rrodionov91 rrodionov91 removed a link to a pull request Nov 10, 2023
Macro: #3475 – Change RNA-preset configuration #3541
Merged
9 tasks
@MartaWilliams MartaWilliams mentioned this issue Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
feature request
Projects
None yet
Milestone
Macromolecules Other Tasks
Development

No branches or pull requests
5 participants
@rrodionov91 @chgayane @OlZhur @olganaz @urszula-gawlowska