Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: When switching from the Macromolecules module to the Molecules module an application crashes #3498

Closed
ViktoriaTkacheva opened this issue Oct 24, 2023 · 2 comments · Fixed by #3552
Closed

Macro: When switching from the Macromolecules module to the Molecules module an application crashes #3498

ViktoriaTkacheva opened this issue Oct 24, 2023 · 2 comments · Fixed by #3552
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: High
Milestone
Macromolecules Mi...

Comments

@ViktoriaTkacheva
Copy link
Collaborator

ViktoriaTkacheva commented Oct 24, 2023 •
edited by Zhirnoff
Loading

Steps to Reproduce

  1. Launch "Ketcher" and go to the Macromolecules module
  2. Open the Console
  3. Inside the "RNA" section in the "Sugars" subsection, select any sugar
  4. Inside the "RNA" section in the "Bases" subsection, select any base
  5. Inside the "RNA" section in the "Phosphates" subsection, select any phosphate
  6. In the "RNA Builder" subsection, click on the "Add to Presets" button
  7. In the "Presets" subsection, click on this added preset
  8. Click on any empty place on the canvas
  9. Go to the Molecules module

Actual behavior
When switching from the Macromolecules module to the Molecules module an application crashes

Expected behavior
Switching from the Macromolecules module to the Molecules module should not crash application

Screenshots

2023-10-24_17h30_20.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (117.0.5938.152) x64

Ketcher version 0.1.0
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 2 milestone Oct 25, 2023
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 6, 2023

Autotest added.

@Zhirnoff Zhirnoff changed the title Macro: when switching from the Macromolecules module to the Molecules module errors appear in the Console Macro: when switching from the Macromolecules module to the Molecules module an application crashes Nov 7, 2023
@Zhirnoff Zhirnoff changed the title Macro: when switching from the Macromolecules module to the Molecules module an application crashes Macro: When switching from the Macromolecules module to the Molecules module an application crashes Nov 7, 2023
rrodionov91 added a commit that referenced this issue Nov 8, 2023
@rrodionov91
#3498 - Macro: When switching from the Macromolecules module to the M…
dd0b049 
…olecules module an application crashes

- added handling the cae when monomer doesn't have specific attachment point but we added bond to it.
@rrodionov91 rrodionov91 mentioned this issue Nov 8, 2023
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Nov 8, 2023
@rrodionov91
Macro: #3498 - When switching from the Macromolecules module to the M…
d723b1d 
…olecules module an application crashes (#3552)

* #3498 - Macro: When switching from the Macromolecules module to the Molecules module an application crashes
- added handling the cae when monomer doesn't have specific attachment point but we added bond to it.
@AnastasiyaPiatrovaKlu
Copy link
Collaborator

AnastasiyaPiatrovaKlu commented Nov 20, 2023 •
edited
Loading

Tested and passed.

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: High
Projects
Ketcher
Status: Done
Milestone
Macromolecules Milestone 2
5 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @AnastasiyaPiatrovaKlu @ViktoriaTkacheva