Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Labels in attachment points selection popup are small for large molecules #3530

Closed
rrodionov91 opened this issue Nov 2, 2023 · 1 comment · Fixed by #3626
Closed

Macro: Labels in attachment points selection popup are small for large molecules #3530

rrodionov91 opened this issue Nov 2, 2023 · 1 comment · Fixed by #3626
Assignees
@chgayane
Labels
bug Priority: Medium
Milestone
Macromolecules Mi...

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Nov 2, 2023 •
edited
Loading

Steps to Reproduce

  1. Add 2 Chems with name "Test-6-AP-Chem"
  2. Drag a bond between chems
  3. Popup with monomer previews appeared

Actual behavior
R1..Rn labels too small
image

Solution
Implement minimum labels size to display only rectangles without text if font-size too small.
@rrodionov91 rrodionov91 added the bug label Nov 2, 2023
@rrodionov91 rrodionov91 added this to the Macromolecules Milestone 2 milestone Nov 2, 2023
@rrodionov91 rrodionov91 assigned chgayane and unassigned Nitvex Nov 23, 2023
chgayane added a commit that referenced this issue Nov 28, 2023
@chgayane
#3530 - selection popup attachment points are removed for complicated…
83862fd 
… structures
chgayane added a commit that referenced this issue Nov 28, 2023
@chgayane
#3530 - selection popup attachment points are removed for complicated…
034302a 
… structures
chgayane added a commit that referenced this issue Nov 28, 2023
@chgayane
#3530 - updated unit test
7b64795
chgayane added a commit that referenced this issue Nov 28, 2023
@chgayane
#3530 - updated unit test
991e243
@chgayane chgayane linked a pull request Nov 28, 2023 that will close this issue
Macro: #3530 - Labels in attachment points selection popup are small for large molecules #3626
Merged
9 tasks
chgayane added a commit that referenced this issue Nov 29, 2023
@chgayane
#3530 - some refactoring
b715583
chgayane added a commit that referenced this issue Nov 29, 2023
@chgayane
#3530 - some refactoring
2f67b52
chgayane added a commit that referenced this issue Nov 29, 2023
@chgayane
#3530 - updated screenshots
f53e60d
chgayane added a commit that referenced this issue Nov 29, 2023
@chgayane
#3530 - some refactoring
1b12b0d
chgayane added a commit that referenced this issue Nov 30, 2023
@chgayane
#3530 - font size changes
3b1192f
rrodionov91 pushed a commit that referenced this issue Nov 30, 2023
@chgayane
Macro: #3530 - Labels in attachment points selection popup are small …
caaf9cf 
…for large molecules (#3626)
@Zhirnoff
Copy link
Collaborator

Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
bug Priority: Medium
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
6 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff @chgayane @OlZhur