Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: AP are shown after closing modal #3582

Closed
OlgaMazurina opened this issue Nov 16, 2023 · 2 comments · Fixed by #3587
Closed

Macro: AP are shown after closing modal #3582

OlgaMazurina opened this issue Nov 16, 2023 · 2 comments · Fixed by #3587
Assignees
@OlgaMazurina
Labels
bug Priority: Low
Milestone
Macromolecules Mi...

Comments

@OlgaMazurina
Copy link
Collaborator

Steps to Reproduce

  1. Add 2 monomers to canvas
  2. Connect 1 monomer to 2
  3. Cancel bond creation

Actual behavior
AP are drawn on the second monomer

Expected behavior
AP should be deleted

Screenshots

Снимок экрана 2023-11-16 в 12 51 02
@OlgaMazurina OlgaMazurina self-assigned this Nov 16, 2023
@OlgaMazurina OlgaMazurina changed the title Macro: When canceling the connection between molecules remains AP are shown Macro: When canceling the connection between molecules AP are shown Nov 16, 2023
@OlgaMazurina OlgaMazurina changed the title Macro: When canceling the connection between molecules AP are shown Macro: AP are shown after closing modal Nov 16, 2023
OlgaMazurina pushed a commit that referenced this issue Nov 17, 2023
#3582 - fix bug
9f0877c
@OlgaMazurina OlgaMazurina linked a pull request Nov 17, 2023 that will close this issue
#3582 - AP are shown after closing modal #3587
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 21, 2023
@OlgaMazurina
#3582 - AP are shown after closing modal (#3587)
1520449 
Co-authored-by: Olga Mazurina <olga_mazurina@epam.com>
@Zhirnoff
Copy link
Collaborator

Manual tests added to the automation table.

@Zhirnoff
Copy link
Collaborator

Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlgaMazurina OlgaMazurina

Labels
bug Priority: Low
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3582 - AP are shown after closing modal epam/ketcher
4 participants
@AlexeyGirin @Zhirnoff @OlgaMazurina @y-holik