Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: selected AP is duplicated while drawing the bond #3583

Closed
OlgaMazurina opened this issue Nov 16, 2023 · 2 comments · Fixed by #3602
Closed

Macro: selected AP is duplicated while drawing the bond #3583

OlgaMazurina opened this issue Nov 16, 2023 · 2 comments · Fixed by #3602
Assignees
@OlgaMazurina
Labels
bug Priority: Low
Milestone
Macromolecules Mi...

Comments

@OlgaMazurina
Copy link
Collaborator

Steps to Reproduce

  1. Add monomer to canvas
  2. Select AP and start to draw bond around the monomer with opened console
Screen.Recording.2023-11-16.at.15.24.40.mov

Actual behavior
AP shouldn't be duplicated
@OlgaMazurina OlgaMazurina changed the title Macro: selected AP is duplicated when you draw the bond Macro: selected AP is duplicated while drawing the bond Nov 16, 2023
@OlgaMazurina OlgaMazurina assigned OlgaMazurina and unassigned Nitvex Nov 20, 2023
@OlgaMazurina OlgaMazurina linked a pull request Nov 21, 2023 that will close this issue
#3583 - selected AP is duplicated while drawing the bond #3602
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 22, 2023
@OlgaMazurina
#3583 - selected AP is duplicated while drawing the bond (#3602)
36cc322 
* 3583 - add redrawAttachmentPointsCoordinates
* 3583 - invoke redrawing attachment points if sector is occupied

---------

Co-authored-by: Olga Mazurina <olga_mazurina@epam.com>
captain2b pushed a commit that referenced this issue Nov 28, 2023
@OlgaMazurina
#3583 - selected AP is duplicated while drawing the bond (#3602)
b8831d3 
* 3583 - add redrawAttachmentPointsCoordinates
* 3583 - invoke redrawing attachment points if sector is occupied

---------

Co-authored-by: Olga Mazurina <olga_mazurina@epam.com>
@Zhirnoff
Copy link
Collaborator

Manual tests added to the automation table.

@Zhirnoff
Copy link
Collaborator

Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlgaMazurina OlgaMazurina

Labels
bug Priority: Low
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3583 - selected AP is duplicated while drawing the bond epam/ketcher
5 participants
@AlexeyGirin @Nitvex @Zhirnoff @OlgaMazurina @y-holik