Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: attachment points aren't disappearing in snake viewed chain of peptides when hovering them multiple times #3601

Closed
y-holik opened this issue Nov 21, 2023 · 2 comments · Fixed by #3628 or #3700
Closed

Macro: attachment points aren't disappearing in snake viewed chain of peptides when hovering them multiple times #3601

y-holik opened this issue Nov 21, 2023 · 2 comments · Fixed by #3628 or #3700
Assignees
@AlexeyGirin
Labels
bug Macromolecules Priority: Medium
Milestone
Macromolecules Mi...

Comments

@y-holik
Copy link
Collaborator

y-holik commented Nov 21, 2023

Steps to Reproduce

  1. Switch to macromolecules
  2. Place multiple peptides on canvas and bond them
  3. Click snake view
  4. Randomly hover mouse over peptide chain (bond tool must be selected)

Actual behavior
Attachment points are always shown for random peptides

Expected behavior
Attachment points should disappear if monomer is not hovered

Screenshots

Screenshot 2023-11-21 at 4 33 25 PM

=
@y-holik y-holik added this to the Macromolecules Milestone 3 milestone Nov 21, 2023
@StarlaStarla StarlaStarla assigned StarlaStarla and unassigned Nitvex Nov 24, 2023
StarlaStarla added a commit that referenced this issue Nov 29, 2023
@StarlaStarla
#3601 fix bug by reusing the aps
53fcffb
@StarlaStarla StarlaStarla linked a pull request Nov 29, 2023 that will close this issue
Macro: #3601 - attachment points aren't disappearing in snake viewed chain of peptides when hovering them multiple times #3628
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Dec 1, 2023
@StarlaStarla
#3601 add autotest
e56c454
StarlaStarla added a commit that referenced this issue Dec 1, 2023
@StarlaStarla
#3601 enhance according to comments
e0c38bd
StarlaStarla added a commit that referenced this issue Dec 4, 2023
@StarlaStarla
#3601 fix typo
7d8dcb0
Nitvex added a commit that referenced this issue Dec 7, 2023
@Nitvex
#3601 – solution refactoring; added types
f6cc15a
Nitvex added a commit that referenced this issue Dec 7, 2023
@StarlaStarla @Nitvex
Macro: #3601 - attachment points aren't disappearing in snake viewed …
1cdc04e 
…chain of peptides when hovering them multiple times (#3628)

* #3601 fix bug by reusing the aps

* #3601 add autotest

* #3601 enhance according to comments

* #3601 fix typo

* #3601 – solution refactoring; added types

---------

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Nitvex added a commit that referenced this issue Dec 14, 2023
@Nitvex
#3601 – Macro: attachment points aren't disappearing in snake viewed …
f2d877a 
…chain of peptides when hovering them multiple times
@Nitvex Nitvex mentioned this issue Dec 14, 2023
Merged
9 tasks
Nitvex added a commit that referenced this issue Dec 14, 2023
@Nitvex
Macro: #3601 – attachment points aren't disappearing in snake viewed …
82d6fa4 
…chain of peptides when hovering them multiple times (#3700)
@Zhirnoff
Copy link
Collaborator

Test added to the table.

@AlexeyGirin
Copy link
Collaborator

Verified.

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyGirin AlexeyGirin

Labels
bug Macromolecules Priority: Medium
Projects
Ketcher
Status: Done
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
5 participants
@AlexeyGirin @StarlaStarla @Nitvex @Zhirnoff @y-holik