Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: preview window of micro structure shows pieces of macro structures #3604

Closed
y-holik opened this issue Nov 21, 2023 · 1 comment · Fixed by #3624
Closed

Macro: preview window of micro structure shows pieces of macro structures #3604

y-holik opened this issue Nov 21, 2023 · 1 comment · Fixed by #3624
Assignees
@ivan-arkhipov-epam
Labels
bug Macromolecules Priority: Medium
Milestone
Macromolecules Mi...

Comments

@y-holik
Copy link
Collaborator

y-holik commented Nov 21, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to macromolecules
  2. Place multiple monomers on canvas and bond them
  3. Switch to micro mode and place Benzene ring on canvas
  4. Select bond tool and bond benzene ring to macro structure
  5. Switch back to macro mode and hover mouse over micro structure to get preview window appeared

Actual behavior
preview window of micro structure shows pieces of macro structures

Expected behavior
preview window of micro structures in macro mode should only show preview of micro structure

Screenshots

Screen.Recording.2023-11-21.at.8.32.52.PM.mov
@y-holik y-holik added the bug label Nov 21, 2023
@y-holik y-holik changed the title Macro: preview window of micro struc Macro: preview window of micro structure shows pieces of macro structures Nov 21, 2023
@y-holik y-holik added this to the Macromolecules Milestone 3 milestone Nov 21, 2023
@OlZhur OlZhur mentioned this issue Nov 23, 2023
Closed
@OlZhur
Copy link
Collaborator

OlZhur commented Nov 23, 2023

After fixing need to check the bug #3611

@ivan-arkhipov-epam ivan-arkhipov-epam linked a pull request Nov 28, 2023 that will close this issue
#3604 macro preview window of micro structure shows pieces of macro structures #3624
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 28, 2023
@ivan-arkhipov-epam
#3604 macro preview window of micro structure shows pieces of macro s…
3065491 
…tructures (#3624)

* Prevented interaction with macro molecules in micromolecules mode
* Fixed unrelated eslint and TS issue
* Added the same restriction to Chain tool
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-arkhipov-epam ivan-arkhipov-epam

Labels
bug Macromolecules Priority: Medium
Projects
Ketcher
Status: Done
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3604 macro preview window of micro structure shows pieces of macro structures epam/ketcher
5 participants
@AlexeyGirin @Nitvex @ivan-arkhipov-epam @OlZhur @y-holik