Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Different coordinate systems are used in Micro and Macro mode #3651

Closed
Nitvex opened this issue Dec 5, 2023 · 1 comment · Fixed by #3726, #3760 or #3776
Closed

Macro: Different coordinate systems are used in Micro and Macro mode #3651

Nitvex opened this issue Dec 5, 2023 · 1 comment · Fixed by #3726, #3760 or #3776
Assignees
@rrodionov91 @Konstantin1996
Labels
Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Dec 5, 2023

Steps to Reproduce
At the moment, coordinate systems are done differently in micro and macro mode. This results in structures being rotated by 180 degrees, when exporting to other molecule sketcher tools or sent to Indigo.

Actual behavior
The structure is rotated by 180 degrees, when exporting to other tools and when sending to Indigo (can be checked with, for example, generateImage API call)

Expected behavior
When pasting to other tools and sending to Indigo a structure is shown as it is drawn in Ketcher

Additional context
image
@Nitvex Nitvex added the bug label Dec 5, 2023
@Nitvex Nitvex added this to the Macromolecules Milestone 4 milestone Dec 5, 2023
@Nitvex Nitvex self-assigned this Dec 5, 2023
@OlZhur OlZhur assigned rrodionov91 and unassigned Nitvex Dec 12, 2023
@Konstantin1996 Konstantin1996 self-assigned this Dec 15, 2023
@rrodionov91 rrodionov91 changed the title [DRAFT] Different coordinate systems are used in Micro and Macro mode Macro: Different coordinate systems are used in Micro and Macro mode Dec 18, 2023
@Konstantin1996 Konstantin1996 mentioned this issue Dec 18, 2023
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Dec 21, 2023
@Konstantin1996
#3651 - different coordinate systems are used in micro and macro mode (…
d4981dc 
…#3726)

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
@Konstantin1996 Konstantin1996 mentioned this issue Dec 21, 2023
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 21, 2023
@Konstantin1996 @rrodionov91
#3651 - different coordinate systems are used in micro and macro mode (…
62fb1e4 
…#3760)

* - added comment
* - removed z coordinate

---------

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Dec 22, 2023
@rrodionov91
#3651 - - different coordinate systems are used in micro and macro mode
9258237 
- excluded z coordinate to be serialized in ket
@rrodionov91 rrodionov91 linked a pull request Dec 22, 2023 that will close this issue
#3651 - Macro: different coordinate systems are used in micro and macro mode #3776
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 22, 2023
@rrodionov91
#3651 - Macro: different coordinate systems are used in micro and mac…
ae6041f 
…ro mode (#3776)

* #3651 - - different coordinate systems are used in micro and macro mode

- excluded z coordinate to be serialized in ket

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

@Konstantin1996 Konstantin1996

Labels
Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
6 participants
@rrodionov91 @AlexeyGirin @Konstantin1996 @Nitvex @Zhirnoff @OlZhur