Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: After opening a file in macro mode, structure is not in center of the screen and need scroll to find it #3666

Closed
Zhirnoff opened this issue Dec 7, 2023 · 2 comments · Fixed by #3782
Closed

Macro: After opening a file in macro mode, structure is not in center of the screen and need scroll to find it #3666

Zhirnoff opened this issue Dec 7, 2023 · 2 comments · Fixed by #3782
Assignees
@StarlaStarla
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.18.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 7, 2023

Steps to Reproduce

  1. Switch to Macro mode
  2. Open file peptide_Bzl.zip

Actual behavior
After opening a file in macro mode, structure is not in center of the screen but at the top. You have to scroll to find the open structure.

Expected behavior
After opening a file in macro mode, structure is in center of the screen.

Screenshots

2023-12-07_18h52_36.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.1
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 4 milestone Dec 7, 2023
@Zhirnoff
Copy link
Collaborator Author

Autotests added.

StarlaStarla added a commit that referenced this issue Dec 23, 2023
@StarlaStarla
#3666 make opening structure in center of the screen
b7738bf
@StarlaStarla StarlaStarla linked a pull request Dec 23, 2023 that will close this issue
Macro: #3666 - After opening a file in macro mode, structure is not in center of the screen and need scroll to find it #3782
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Dec 25, 2023
@StarlaStarla
#3666 make opening structure in center of the screen
ba2f87a
StarlaStarla added a commit that referenced this issue Dec 25, 2023
@StarlaStarla
#3666 update autotests
894a46f
StarlaStarla added a commit that referenced this issue Dec 25, 2023
@StarlaStarla
#3666 update test screenshots
6c037a2
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 separate serializer and center logic
350bc83
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 separate serializer and center logic
e84f152
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 fix issues
a8ce1e9
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 fix pipeline issues
2e5467f
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 fix ci issue
7f86fb2
StarlaStarla added a commit that referenced this issue Dec 26, 2023
@StarlaStarla
#3666 fix sreenshots and circular dependencies
d23172b
StarlaStarla added a commit that referenced this issue Dec 27, 2023
@StarlaStarla
#3666 revert import change and change center logic to DrawingEntities…
644085e 
…Manager
StarlaStarla added a commit that referenced this issue Dec 27, 2023
@StarlaStarla
#3666 fix autotest
d4c02cd
StarlaStarla added a commit that referenced this issue Dec 27, 2023
@StarlaStarla
#3666 move get center-of-canvas logic to view layer
735f75b
Nitvex pushed a commit that referenced this issue Dec 27, 2023
@StarlaStarla
Macro: #3666 - After opening a file in macro mode, structure is not i…
0dd8f67 
…n center of the screen and need scroll to find it (#3782)

* #3666 make opening structure in center of the screen

* #3666 update autotests

* #3666  update test screenshots

* #3666 separate serializer and center logic

* #3666 fix issues

* #3666 fix pipeline issues

* #3666 fix ci issue

* #3666 revert import change and change center logic to DrawingEntitiesManager

* #3666 fix autotest

* #3666 move get center-of-canvas logic to view layer
@rrodionov91 rrodionov91 removed this from the Macromolecules Milestone 4 milestone Jan 12, 2024
@rrodionov91 rrodionov91 added this to the Ketcher 2.18.0-rc.1 milestone Jan 12, 2024
@Zhirnoff
Copy link
Collaborator Author

Tested. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
5 participants
@rrodionov91 @AlexeyGirin @StarlaStarla @Zhirnoff @OlZhur