Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Leaving groups are not displayed correctly in preview when switching to Micro mode #3692

Closed
Zhirnoff opened this issue Dec 13, 2023 · 2 comments · Fixed by #3825
Closed

Macro: Leaving groups are not displayed correctly in preview when switching to Micro mode #3692

Zhirnoff opened this issue Dec 13, 2023 · 2 comments · Fixed by #3825
Assignees
@StarlaStarla
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.18.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 13, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode
  2. Add any monomer to canvas
  3. Switch to Micro mode
  4. Hover over monomer

Actual behavior
Leaving groups are not displayed correctly in preview.
When we switch to micro mod, attachment point icons are shown
2023-12-13_03h07_38

Expected behavior
2023-12-13_03h10_17

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.17.0-rc.1
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 4 milestone Dec 13, 2023
@Zhirnoff Zhirnoff changed the title Macro: Living groups are not displayed correctly in preview Macro: Living groups are not displayed correctly in preview when switching to Micro mode Dec 13, 2023
@Zhirnoff Zhirnoff changed the title Macro: Living groups are not displayed correctly in preview when switching to Micro mode Macro: Leaving groups are not displayed correctly in preview when switching to Micro mode Dec 13, 2023
@rrodionov91 rrodionov91 assigned Nitvex and unassigned rrodionov91 and Nitvex Dec 26, 2023
@StarlaStarla StarlaStarla self-assigned this Jan 2, 2024
StarlaStarla added a commit that referenced this issue Jan 2, 2024
@StarlaStarla
#3692 hide attachment points for micro preview
b07d08a
@StarlaStarla StarlaStarla linked a pull request Jan 2, 2024 that will close this issue
Macro: #3692 - Leaving groups are not displayed correctly in preview when switching to Micro mode #3825
Merged
9 tasks
StarlaStarla added a commit that referenced this issue Jan 3, 2024
@StarlaStarla
#3692 hide attachment points for micro preview
fdd1c31
StarlaStarla added a commit that referenced this issue Jan 3, 2024
@StarlaStarla
#3692 hide attachment points for micro preview
62705af
StarlaStarla added a commit that referenced this issue Jan 3, 2024
@StarlaStarla
#3692 update screenshots
339827d
rrodionov91 added a commit that referenced this issue Jan 3, 2024
@StarlaStarla @rrodionov91
Macro: #3692 - Leaving groups are not displayed correctly in preview …
22282a3 
…when switching to Micro mode (#3825)

- hide attachment points for micro preview

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jan 4, 2024

Test added to automation table.

@Zhirnoff
Copy link
Collaborator Author

Tested. No comments.
2024-01-16_15h53_41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
5 participants
@rrodionov91 @AlexeyGirin @StarlaStarla @Nitvex @Zhirnoff