Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Pressing Layout/Clean Up button cleanup all macromoleculas from canvas #3712

Closed
AlexeyGirin opened this issue Dec 18, 2023 · 3 comments · Fixed by #3821
Closed

Macro: Pressing Layout/Clean Up button cleanup all macromoleculas from canvas #3712

AlexeyGirin opened this issue Dec 18, 2023 · 3 comments · Fixed by #3821
Assignees
@rrodionov91
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 18, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to Macromolecules
  2. Put any peptide on canvas (it was A in my case)
  3. Switch to Molecules
  4. Press Layout button (or Clean Up button)

Actual behavior
Macromolecula disappeared from canvas

Expected behavior
Macromolecula remain on canvas

Desktop (please complete the following information):

  • OS: win10
  • Browser: Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
2.17.0-rc.2
@AlexeyGirin AlexeyGirin changed the title Macro: Pressing Layout button cleanup all macromoleculas from canvas Macro: Pressing Layout/Clean Up button cleanup all macromoleculas from canvas Dec 18, 2023
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned Nitvex Dec 26, 2023
rrodionov91 added a commit that referenced this issue Dec 28, 2023
@rrodionov91
#3712 - Macro: Pressing Layout/Clean Up button cleanup all macromolec…
6cdae07 
…ulas from canvas

- fixed macromolecules cloning in struct to include it into ket for indigo layout
@rrodionov91 rrodionov91 linked a pull request Dec 28, 2023 that will close this issue
#3712 - Macro: Pressing Layout/Clean Up button cleanup all macromoleculas from canvas #3821
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Dec 29, 2023
@rrodionov91
#3712 - Macro: Pressing Layout/Clean Up button cleanup all macromolec…
617edf5 
…ulas from canvas (#3821)

- fixed macromolecules cloning in struct to include it into ket for indigo layout

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 4, 2024

Tests added to automation table.

@AlexeyGirin
Copy link
Collaborator Author

Fixed.

@NadezhdaPeskun NadezhdaPeskun mentioned this issue Mar 20, 2024
Closed
@NadezhdaPeskun NadezhdaPeskun added the Macro-Micro Bucket: Macro-Micro View related issues label Mar 20, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented May 6, 2024

Automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
Development

Successfully merging a pull request may close this issue.

#3712 - Macro: Pressing Layout/Clean Up button cleanup all macromoleculas from canvas epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff @NadezhdaPeskun