Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Save to file and than Load it back eliminate monomer names from preview tooltip #3757

Closed
AlexeyGirin opened this issue Dec 21, 2023 · 3 comments · Fixed by #3828
Closed

Macro: Save to file and than Load it back eliminate monomer names from preview tooltip #3757

AlexeyGirin opened this issue Dec 21, 2023 · 3 comments · Fixed by #3828
Assignees
@rrodionov91
Labels
bug Priority: Medium
Milestone
Ketcher 2.18.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 21, 2023 •
edited
Loading

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: Alanine.zip (unzip first)
    System loads one monomer:
    image
  3. Go to Library/Peptides and put Alanine to canvas (to have it two)
    image
  4. Hover mouse cursor over one monomer and than over added one

Actual behavior
From file:
image
Added one:
image
Note that peptide loaded from file - name is missing
image
I tried ket and mol files - it works the same for any monomer type.

Expected behavior
It should not be any differences between instance loaded from the file and from Library

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
image
Additional context
Add any other context about the problem here.
@AlexeyGirin AlexeyGirin changed the title Macro: Save to file and than Load back eliminate monomer names from preview tooltip Macro: Save to file and than Load it back eliminate monomer names from preview tooltip Dec 21, 2023
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned rrodionov91 and Nitvex Dec 26, 2023
@rrodionov91 rrodionov91 self-assigned this Jan 3, 2024
rrodionov91 added a commit that referenced this issue Jan 3, 2024
@rrodionov91
#3757 - Macro: Save to file and than Load it back eliminate monomer n…
c39f37a 
…ames from preview tooltip

- fixed monomer fullname during saving and opening
@rrodionov91 rrodionov91 linked a pull request Jan 3, 2024 that will close this issue
Macro: #3757 - Save to file and than Load it back eliminate monomer names from preview tooltip #3828
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 4, 2024

Test added to automation table.

Nitvex pushed a commit that referenced this issue Jan 4, 2024
@rrodionov91
Macro: #3757 - Save to file and than Load it back eliminate monomer n…
b70f39a 
…ames from preview tooltip (#3828)

* #3757 - Macro: Save to file and than Load it back eliminate monomer names from preview tooltip

- fixed monomer fullname during saving and opening

* - fixed test mocks

* - fixed test mocks

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@AlexeyGirin
Copy link
Collaborator Author

Fixed for ket format but not for mol. Mol doesn't support labels

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 18, 2024 •
edited
Loading

Bug fixed for ket. files but when saving in mol. and opening on tooltips there are no names. Apparently the mol. format itself is does not support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.1
4 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff