Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Lack of consistency in hotkeys between micro and macro mods and absence of tooltips with information about hotkeys in macro mod. #3917

Closed
Zhirnoff opened this issue Jan 17, 2024 · 1 comment · Fixed by #3929 or #3945
Closed

Macro: Lack of consistency in hotkeys between micro and macro mods and absence of tooltips with information about hotkeys in macro mod. #3917

Zhirnoff opened this issue Jan 17, 2024 · 1 comment · Fixed by #3929 or #3945
Assignees
@ilya-asiyuk-epam
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.18.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher and try hotkeys in Macro and Micro mode.
  2. Hover any button for which a hotkey is assigned

Actual behavior
In Macro mode not working Clear canvas hotkey: Ctrl+Del and in Micro mode not working: Ctrl+Backspace
In Macro mode not working Redo: Ctrl+Y
Hotkeys are not indicated in tooltips. There are no tooltips for Undo and Redo at all.

Expected behavior
All declared hotkeys work in both modes.
Hotkeys are indicated in tooltips. There are tooltips for Undo and Redo.

Screenshots

2024-01-17_14h53_29

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.18.0-rc.3 milestone Jan 17, 2024
@Zhirnoff Zhirnoff mentioned this issue Jan 17, 2024
Closed
ilya-asiyuk-epam added a commit that referenced this issue Jan 18, 2024
@ilya-asiyuk-epam
#3917 - Macro: Hot keys for toolbar buttons are not implemented in Ma…
49ab39b 
…cromoleculas view
ilya-asiyuk-epam added a commit that referenced this issue Jan 18, 2024
@ilya-asiyuk-epam
#3917 - Macro: Hot keys for toolbar buttons are not implemented in Ma…
30ea57f 
…cromoleculas view
ilya-asiyuk-epam added a commit that referenced this issue Jan 18, 2024
@ilya-asiyuk-epam
#3917 - Macro: Lack of consistency in hotkeys between micro and macro…
55a30a9 
… mods and absence of tooltips with information about hotkeys in macro mod.
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Jan 18, 2024 that will close this issue
#3917 - Macro: Lack of consistency in hotkeys between micro and macro mods and absence of tooltips with information about hotkeys #3929
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Jan 22, 2024
@ilya-asiyuk-epam
#3917 - Macro: Lack of consistency in hotkeys between micro and macro…
d78981b 
… mods and absence of tooltips with information about hotkeys in macro mod.
ilya-asiyuk-epam added a commit that referenced this issue Jan 22, 2024
@ilya-asiyuk-epam
#3917 - Macro: Lack of consistency in hotkeys between micro and macro…
93529a2 
… mods and absence of tooltips with information about hotkeys in macro mod.
rrodionov91 pushed a commit that referenced this issue Jan 23, 2024
@ilya-asiyuk-epam
#3917 - Macro: Lack of consistency in hotkeys between micro and macro…
7e35d07 
… mods and absence of tooltips with information about hotkeys in macro mod. (#3929)
ilya-asiyuk-epam added a commit that referenced this issue Jan 23, 2024
@ilya-asiyuk-epam
Backmerge: #3917 - Macro: Lack of consistency in hotkeys between micr…
4535a24 
…o and macro mods and absence of tooltips with information about hotkeys in macro mod.
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Jan 23, 2024 that will close this issue
Backmerge: #3917 - Macro: Lack of consistency in hotkeys between micro and macro mods and absence of tooltips with information about hotkeys in macro mod. #3945
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 25, 2024
@ilya-asiyuk-epam
Backmerge: #3917 - Macro: Lack of consistency in hotkeys between micr…
041219b 
…o and macro mods and absence of tooltips with information about hotkeys in macro mod. (#3945)
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Feb 1, 2024

Tested. Bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.18.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @ilya-asiyuk-epam