Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: After pressing Snake mode, attachment points stick out in different directions and not attached to the bonds #3919

Closed
Zhirnoff opened this issue Jan 17, 2024 · 4 comments · Fixed by #3911, #4034, #4035 or #4482
Closed

Macro: After pressing Snake mode, attachment points stick out in different directions and not attached to the bonds #3919

Zhirnoff opened this issue Jan 17, 2024 · 4 comments · Fixed by #3911, #4034, #4035 or #4482
Assignees
@chgayane
Labels
Macromolecules Priority: High
Milestone
Ketcher 2.21.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode
  2. Make monomers sequence connected by bonds
  3. Hover over monomer and move away mouse cursor when bonds freezes
  4. Press Snake mode

Actual behavior
After pressing Snake mode, attachment points stick out in different directions and not attached to the bonds.
Expected behavior
After pressing Snake mode, bonds are connected to monomers and attachment points do not stick out in different directions.

Screenshots

Recording.2024-01-17.150432.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.1]
@Zhirnoff Zhirnoff added this to the Ketcher 2.18.0-rc.3 milestone Jan 17, 2024
@rrodionov91 rrodionov91 linked a pull request Jan 18, 2024 that will close this issue
#3899 - macro attachment points do not disappear when hover is removed from some monomers #3911
Merged
9 tasks
@rrodionov91 rrodionov91 reopened this Jan 18, 2024
@Zhirnoff
Copy link
Collaborator Author

Test added to the automation table.

@rrodionov91 rrodionov91 assigned chgayane and unassigned rrodionov91 Jan 26, 2024
@rrodionov91 rrodionov91 linked a pull request Feb 6, 2024 that will close this issue
Backmerge: Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. #4034
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Feb 6, 2024 that will close this issue
Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. #4035
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Feb 9, 2024

Bug is still reproducing
2024-02-09_17h59_15

@Zhirnoff Zhirnoff reopened this Feb 9, 2024
@rrodionov91 rrodionov91 linked a pull request Apr 17, 2024 that will close this issue
#3899 - Macro: Attachment points do not disappear when hover is removed from some monomers. #4482
Merged
9 tasks
@NadezhdaPeskun
Copy link

Verified as fixed for CI Version
2.21.0-rc.1 Build at 2024-04-26
Indigo Toolkit
Version 1.20.0-dev.1.25-gafde2b35-wasm32-wasm-clang-12.0.0

OS: Windows 11
Browser Chrome
Version 112.0.5615.138 (Official Build) (64-bit)

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented May 7, 2024

Tested on release 2.21.0-rc.2
Fixed.

2024-05-07_16h45_54.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.21.0-rc.2
5 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @chgayane @NadezhdaPeskun