Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3899 - Macro: Attachment points do not disappear when hover is removed from some monomers. #4482

Merged
merged 3 commits into from
Apr 18, 2024
Merged

#3899 - Macro: Attachment points do not disappear when hover is removed from some monomers. #4482

merged 3 commits into from
Apr 18, 2024

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Apr 17, 2024 •
edited
Loading

Closes #3899

  • added AttachmentPoint instance binding to it's html elements
  • added pointer-events: none by default for all elements of attachment point and explicitly pointer-events: auto to it's hover area
  • fixed(reduced) size of attachment point hover area

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@rrodionov91
#3899 - Macro: Attachment points do not disappear when hover is remov…
c5a9bca 
…ed from some monomers.

- added AttachmentPoint instance binding to it's html elements
- added pointer-events: none by default for all elements of attachment point and explicitly pointer-events: auto to it's hover area
@rrodionov91 rrodionov91 mentioned this pull request Apr 17, 2024
Closed
9 tasks
@rrodionov91 rrodionov91 linked an issue Apr 17, 2024 that may be closed by this pull request
Macro: After pressing Snake mode, attachment points stick out in different directions and not attached to the bonds #3919
Closed
@rrodionov91 rrodionov91 merged commit 06dd9f8 into release/2.21 Apr 18, 2024
3 checks passed
@rrodionov91 rrodionov91 deleted the 3899-attachment-points-not-disappear branch April 18, 2024 14:28
@rrodionov91 rrodionov91 mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-asiyuk-epam ilya-asiyuk-epam ilya-asiyuk-epam approved these changes

@StarlaStarla StarlaStarla Awaiting requested review from StarlaStarla

@Zhirnoff Zhirnoff Awaiting requested review from Zhirnoff

Assignees

@rrodionov91 rrodionov91

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rrodionov91 @ilya-asiyuk-epam