Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Attachment points do not disappear when hover is removed from some monomers. #3899

Closed
Zhirnoff opened this issue Jan 15, 2024 · 4 comments · Fixed by #3911, #3933, #4034, #4035 or #4489
Closed

Macro: Attachment points do not disappear when hover is removed from some monomers. #3899

Zhirnoff opened this issue Jan 15, 2024 · 4 comments · Fixed by #3911, #3933, #4034, #4035 or #4489
Assignees
@StarlaStarla
Labels
bug Macromolecules Priority: High
Milestone
Ketcher 2.21.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode
  2. Add monomers to canvas
  3. Select Bond tool
  4. Hover monomers going through one to another
    Note: Also reproduced when hovering monomers connected by bonds

Actual behavior
Attachment points do not disappear when hover is removed from some monomers.

Expected behavior
Attachment points disappear when hover is removed from monomers.

Screenshots

2024-01-15_22h10_57.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.1]
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 5 milestone Jan 15, 2024
@Konstantin1996 Konstantin1996 mentioned this issue Jan 16, 2024
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 18, 2024
@Konstantin1996
#3899 - macro attachment points do not disappear when hover is remove…
bfef1ae 
…d from some monomers

- removed strange setTimeout 1
--
Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
@rrodionov91 rrodionov91 reopened this Jan 18, 2024
@rrodionov91 rrodionov91 linked a pull request Jan 22, 2024 that will close this issue
#3899 - macro attachment points do not disappear when hover is removed from some monomers #3933
Merged
9 tasks
@rrodionov91 rrodionov91 reopened this Jan 22, 2024
chgayane added a commit that referenced this issue Jan 22, 2024
@chgayane
#3899 - Hide attachment points on monomer hover end
a51fc88
@chgayane chgayane linked a pull request Jan 22, 2024 that will close this issue
Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. #3940
Closed
9 tasks
@rrodionov91 rrodionov91 added this to the Ketcher 2.20.0-rc.1 milestone Feb 19, 2024
StarlaStarla added a commit that referenced this issue Mar 4, 2024
@StarlaStarla
#3899 Attachment points do not disappear when hover is removed
db3781a
@StarlaStarla StarlaStarla linked a pull request Mar 4, 2024 that will close this issue
#3899 - Attachment points do not disappear when hover is removed #4190
Closed
9 tasks
StarlaStarla added a commit that referenced this issue Mar 4, 2024
@StarlaStarla
#3899 fix test
12c9187
StarlaStarla added a commit that referenced this issue Mar 4, 2024
@StarlaStarla
#3899 fix test
1b0fd53
StarlaStarla added a commit that referenced this issue Mar 5, 2024
@StarlaStarla
#3899 update screenshot
a640f14
StarlaStarla added a commit that referenced this issue Mar 6, 2024
@StarlaStarla
#3899 fix iissue
807f851
StarlaStarla added a commit that referenced this issue Mar 6, 2024
@StarlaStarla
#3899 fix screenshots
069e14c
StarlaStarla added a commit that referenced this issue Mar 6, 2024
@StarlaStarla
#3899 fix test
2954090
@Zhirnoff Zhirnoff mentioned this issue Mar 28, 2024
Closed
rrodionov91 added a commit that referenced this issue Apr 17, 2024
@rrodionov91
#3899 - Macro: Attachment points do not disappear when hover is remov…
c5a9bca 
…ed from some monomers.

- added AttachmentPoint instance binding to it's html elements
- added pointer-events: none by default for all elements of attachment point and explicitly pointer-events: auto to it's hover area
@rrodionov91 rrodionov91 mentioned this issue Apr 17, 2024
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Apr 18, 2024
@rrodionov91
#3899 - Macro: Attachment points do not disappear when hover is remov…
06dd9f8 
…ed from some monomers. (#4482)

- added AttachmentPoint instance binding to it's html elements
- added pointer-events: none by default for all elements of attachment point and explicitly pointer-events: auto to it's hover area
- fixed(reduced) size of attachment point hover area
- fixed case with switching tool by hotkeys

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Apr 18, 2024
@rrodionov91
#3899 - Macro: Attachment points do not disappear when hover is remov…
7238d24 
…ed from some monomers.

- added AttachmentPoint instance binding to it's html elements
- added pointer-events: none by default for all elements of attachment point and explicitly pointer-events: auto to it's hover area
@rrodionov91 rrodionov91 mentioned this issue Apr 18, 2024
Merged
9 tasks
@rrodionov91
Copy link
Collaborator

Finally fixed in #4482

@NadezhdaPeskun
Copy link

Verified as fixed for CI Version
2.21.0-rc.1 Build at 2024-04-26
Indigo Toolkit
Version 1.20.0-dev.1.25-gafde2b35-wasm32-wasm-clang-12.0.0

OS: Windows 11
Browser Chrome
Version 112.0.5615.138 (Official Build) (64-bit)

@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented May 7, 2024

Tested on release 2.21.0-rc.2
Fixed.

2024-05-07_16h45_54.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.21.0-rc.2
Development

Successfully merging a pull request may close this issue.

3899-macro-attachment-points-do-not-disappear-when-hover-is-removed-from-some-monomers-2 epam/ketcher
#3899 - macro attachment points do not disappear when hover is removed from some monomers epam/ketcher
#3899 - macro attachment points do not disappear when hover is removed from some monomers epam/ketcher
Backmerge: Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. epam/ketcher
Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. epam/ketcher
Backmerge: #3899 - Macro: Attachment points do not disappear when hover is removed from some monomers epam/ketcher
Macro: #3899 - Attachment points do not disappear when hover is removed from some monomers. epam/ketcher
#3899 - Attachment points do not disappear when hover is removed epam/ketcher
7 participants
@rrodionov91 @AlexeyGirin @Konstantin1996 @StarlaStarla @Zhirnoff @chgayane @NadezhdaPeskun