Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System allow to create atoms with Charge value out or range #3943

Closed
AlexeyGirin opened this issue Jan 23, 2024 · 3 comments · Fixed by #4079
Closed

System allow to create atoms with Charge value out or range #3943

AlexeyGirin opened this issue Jan 23, 2024 · 3 comments · Fixed by #4079
Assignees
@DzhafarOFF
Labels
bug Priority: Low Query features Bucket: Query features related issues
Milestone
Refined Backlog

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 23, 2024 •
edited
Loading

Environment details (please complete the following information):

Describe the bug
System allow to create atoms with Charge value out or range
(Former: Unable to load mol file: System throws exception: Cannot set properties of undefined (setting 'charge'))

Steps to Reproduce

  1. Open any atom and try to set Charge value to -111

Actual behavior
System let you to do so
image

Expected behavior
System should validate the value and allow to define only values from allowed range
image
@AlexeyGirin AlexeyGirin added this to the Query Features - Phase II milestone Jan 23, 2024
@AlexeyGirin
Copy link
Collaborator Author

Validation should be added +-15 range allowed only

@AlexeyGirin AlexeyGirin changed the title Unable to load mol file: System throws exception: Cannot set properties of undefined (setting 'charge') System allow to create atoms with Charge value out or range Jan 23, 2024
@Zhirnoff
Copy link
Collaborator

Test automated.

DzhafarOFF pushed a commit that referenced this issue Feb 13, 2024
#3943 - System allow to create atoms with charge value out or range
18b041f
DzhafarOFF pushed a commit that referenced this issue Feb 13, 2024
#3943 - remove unused import
c3129eb
@DzhafarOFF DzhafarOFF linked a pull request Feb 13, 2024 that will close this issue
#3943 - System allow to create atoms with Charge value out or range #4079
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Apr 17, 2024
@rrodionov91
Merge pull request #4079 from epam/3943-system-allow-to-create-atoms-…
c6e7c7c 
…with-charge-value-out-or-range

#3943 - System allow to create atoms with Charge value out or range
@AlexeyGirin AlexeyGirin added the Query features Bucket: Query features related issues label Apr 17, 2024
@AlexeyGirin
Copy link
Collaborator Author

Moved to Refined Backlog since no fix over 3 versions

@github-project-automation github-project-automation bot moved this to Ready for testing in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DzhafarOFF DzhafarOFF

Labels
bug Priority: Low Query features Bucket: Query features related issues
Projects
Ketcher
Status: Ready for testing
Milestone
Refined Backlog
Development

Successfully merging a pull request may close this issue.

#3943 - System allow to create atoms with Charge value out or range epam/ketcher
5 participants
@captain2b @rrodionov91 @AlexeyGirin @DzhafarOFF @Zhirnoff