Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser #4014

Closed
Zhirnoff opened this issue Feb 2, 2024 · 1 comment · Fixed by #4025 or #4033
Closed

Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser #4014

Zhirnoff opened this issue Feb 2, 2024 · 1 comment · Fixed by #4025 or #4033
Assignees
@ilya-asiyuk-epam
Labels
bug Firefox only Macromolecules
Milestone
Ketcher 2.18.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 2, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher and switch to Macro mode
  2. Add several monomers to canvas
  3. Select Single bond tool and try to connect them

Actual behavior

Attachment points are not attached to monomers. It is impossible to connect monomers and there are many errors in DevTool console.

Expected behavior

It is possible to connect monomers.

Screenshots

2024-01-26_22h12_50.mp4
2024-01-26_22h14_44.mp4

Possible related issue: #3980
Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Firefox
  • Version 122.0 (64-bit)

Ketcher version
Version 2.18.0-rc.2
@Zhirnoff Zhirnoff added this to the Ketcher 2.19.0-rc.1 milestone Feb 2, 2024
ilya-asiyuk-epam added a commit that referenced this issue Feb 5, 2024
@ilya-asiyuk-epam
#4014 - Macro: Monomers (attachment points) cannot be connected by a …
3b4908c 
…bond in Firefox browser
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Feb 5, 2024 that will close this issue
#4014 - Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser #4025
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Feb 5, 2024
@ilya-asiyuk-epam
#4014 - Macro: Monomers (attachment points) cannot be connected by a …
b3bfaea 
…bond in Firefox browser
ilya-asiyuk-epam added a commit that referenced this issue Feb 6, 2024
@ilya-asiyuk-epam
Merge pull request #4025 from epam/4014-macro-monomers-attachment-poi…
6b2f58c 
…nts-cannot-be-connected-by-a-bond-in-firefox-browser

#4014 - Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser
ilya-asiyuk-epam added a commit that referenced this issue Feb 6, 2024
@ilya-asiyuk-epam
Backmerge: #4014 - Macro: Monomers (attachment points) cannot be conn…
b4ad47d 
…ected by a bond in Firefox browser
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Feb 6, 2024 that will close this issue
Backmerge: #4014 - Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser #4033
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Feb 6, 2024
@ilya-asiyuk-epam
Merge pull request #4033 from epam/4014-macro-monomers-attachment-poi…
2511f0c 
…nts-cannot-be-connected-by-a-bond-in-firefox-browser

Backmerge: #4014 - Macro: Monomers (attachment points) cannot be connected by a bond in Firefox browser
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Feb 7, 2024

Tested. Bug is fixed. Monomers can be connected with bonds, but the attachment points are still located away from the monomer and this will be fixed in 2.18.0-rc.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Firefox only Macromolecules
Projects
None yet
Milestone
Ketcher 2.18.0-rc.4
3 participants
@rrodionov91 @Zhirnoff @ilya-asiyuk-epam