Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: When monomers are selected 'Del' and 'Backspace' hotkey delete selected monomers and switches to Erase tool #4028

Closed
Zhirnoff opened this issue Feb 5, 2024 · 2 comments · Fixed by #4385 or #4397
Closed

Macro: When monomers are selected 'Del' and 'Backspace' hotkey delete selected monomers and switches to Erase tool #4028

Zhirnoff opened this issue Feb 5, 2024 · 2 comments · Fixed by #4385 or #4397
Assignees
@rrodionov91
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.20.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 5, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode
  2. Add some monomers on canvas
  3. Select with 'Selection tool' some monomers and press 'Del' or 'Backspace'

Actual behavior
When monomers are selected 'Del' and 'Backspace' hotkey delete selected monomers and switches to Erase tool

Expected behavior
When monomers are selected, pressing 'Del' or 'Backspace' hotkey deletes selected monomers without switching to the Erase tool. Should work like in Micro mode.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.3]
@Zhirnoff Zhirnoff added this to the Macromolecules Backlog milestone Feb 5, 2024
@Zhirnoff Zhirnoff changed the title Macro: The 'Del' and 'Backspace' hotkey does not delete monomer when hovering and pressing, but only switches to Erase tool Macro: When monomers are selected 'Del' and 'Backspace' hotkey delete selected monomers and switches to Erase tool Feb 15, 2024
@rrodionov91 rrodionov91 linked a pull request Feb 19, 2024 that will close this issue
#4028 - Macro: The 'Del' and 'Backspace' hotkey does not delete monomer when hovering and pressing, but only switches to Erase tool #4090
Closed
9 tasks
@tmrr13 tmrr13 linked a pull request Feb 27, 2024 that will close this issue
#4028 - Macro: The 'Del' and 'Backspace' hotkey does not delete monomer when hovering and pressing, but only switches to Erase tool #4116
Closed
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Bug prioritized as requested @vanoprenko

tmrr13 added a commit that referenced this issue Apr 1, 2024
@tmrr13
#4028 - Macro: When monomers are selected Del and Backspace hotkey de…
4e8e6af 
…lete selected monomers and switches to Erase tool
This was unlinked from pull requests Apr 1, 2024
#4028 - Macro: The 'Del' and 'Backspace' hotkey does not delete monomer when hovering and pressing, but only switches to Erase tool #4090
Closed
#4028 - Macro: The 'Del' and 'Backspace' hotkey does not delete monomer when hovering and pressing, but only switches to Erase tool #4116
Closed
@tmrr13 tmrr13 linked a pull request Apr 1, 2024 that will close this issue
#4028 - Macro: When monomers are selected Del and Backspace hotkey delete selected monomers and switches to Erase tool #4385
Merged
9 tasks
tmrr13 added a commit that referenced this issue Apr 1, 2024
@tmrr13
#4028 - Macro: When monomers are selected Del and Backspace hotkey de…
2c91136 
…lete selected monomers and switches to Erase tool
NataliaLoginova added a commit that referenced this issue Apr 1, 2024
@NataliaLoginova
Merge pull request #4385 from epam/4028-macro-when-monomers-are-selec…
0bc8caf 
…ted-del-and-backspace-hotkey-delete-selected-monomers-and-switches-to-erase-tool

#4028 - Macro: When monomers are selected Del and Backspace hotkey delete selected monomers and switches to Erase tool
NataliaLoginova added a commit that referenced this issue Apr 2, 2024
@NataliaLoginova
Merge pull request #4385 from epam/4028-macro-when-monomers-are-selec…
9af6cf2 
…ted-del-and-backspace-hotkey-delete-selected-monomers-and-switches-to-erase-tool

#4028 - Macro: When monomers are selected Del and Backspace hotkey delete selected monomers and switches to Erase tool
@NataliaLoginova NataliaLoginova linked a pull request Apr 2, 2024 that will close this issue
Backmerge: #4028 - Macro: When monomers are selected Del and Backspace hotkey delete selected monomers and switches to Erase tool #4397
Merged
9 tasks
NataliaLoginova added a commit that referenced this issue Apr 3, 2024
@NataliaLoginova
Merge pull request #4397 from epam/4028-macro-when-monomers-are-selec…
5aa5612 
…ted-del-and-backspace-hotkey-delete-selected-monomers-and-switches-to-erase-tool

Backmerge: #4028 - Macro: When monomers are selected Del and Backspace hotkey delete selected monomers and switches to Erase tool
@AlexeyGirin
Copy link
Collaborator

Fixed.
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.20.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @ilya-asiyuk-epam