Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hydrogens moves molecules to the center of the screen #4128

Closed
AlexeyGirin opened this issue Feb 22, 2024 · 2 comments · Fixed by #4129, #4130 or #4131
Closed

Adding hydrogens moves molecules to the center of the screen #4128

AlexeyGirin opened this issue Feb 22, 2024 · 2 comments · Fixed by #4129, #4130 or #4131
Assignees
@rrodionov91
Labels
Priority: High query features phase II
Milestone
Ketcher 2.18.0-rc.8

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Feb 22, 2024 •
edited
Loading

Describe the bug
Adding hydrogens moves molecules to the center of the screen

Steps to Reproduce

  1. Put benzene ring to the corner of canvas
  2. Press Add/Remove hydrogens button
    image

Actual behavior
System moves molecule to the center of canvas
image

Expected behavior
Molecule remain in place
image

Ketcher version
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.18.0-rc.8 milestone Feb 22, 2024
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
#4128 - Adding hydrogens moves molecules to the center of the screen
8ed090f 
- removed centering after hydrogenization
@rrodionov91 rrodionov91 linked a pull request Feb 22, 2024 that will close this issue
#4128 - Adding hydrogens moves molecules to the center of the screen #4129
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
#4128 - Adding hydrogens moves molecules to the center of the screen (#…
09e2a49 
…4129)

- removed centering after hydrogenization
- fixed tests

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
#4128 - Adding hydrogens moves molecules to the center of the screen
2b1378a 
- removed centering after hydrogenization
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
#4128 - Adding hydrogens moves molecules to the center of the screen
2bfca61 
- removed centering after hydrogenization
This was linked to pull requests Feb 22, 2024
Backmerge: #4128 - Adding hydrogens moves molecules to the center of the screen #4130
Merged
Backmerge: #4128 - Adding hydrogens moves molecules to the center of the screen #4131
Merged
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
Backmerge: #4128 - Adding hydrogens moves molecules to the center of …
68d4f19 
…the screen (#4131)

- removed centering after hydrogenization
- fixed tests

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
Backmerge: #4128 - Adding hydrogens moves molecules to the center of …
c872aa3 
…the screen (#4130)

- removed centering after hydrogenization
- fixed tests

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
Ketcher Version 2.18.0-rc.8 Build at 2024-02-22; 17:29:02
Indigo Toolkit Version 1.18.0-rc.8.0-g85a393c7c-wasm32-wasm-clang-12.0.0

image

@Zhirnoff
Copy link
Collaborator

Test automated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Priority: High query features phase II
Projects
None yet
Milestone
Ketcher 2.18.0-rc.8
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff