Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: UI for Open/Save As FASTA #4146

Closed
olganaz opened this issue Feb 23, 2024 · 2 comments · Fixed by #4240
Closed

Macro: UI for Open/Save As FASTA #4146

olganaz opened this issue Feb 23, 2024 · 2 comments · Fixed by #4240
Assignees
@ilya-asiyuk-epam
Labels
feature request
Milestone
Ketcher 2.20.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Feb 23, 2024 •
edited by even1024
Loading

Requirements

Open

  • Add option "FASTA" to the format dropdown menu of modal window 'Open'/'Paste from the clipboard'
  • When "FASTA" format is chosen additional options should be displayed (similar like for Sequence):
    - RNA
    - DNA
    - Peptide

Save As

  • Add option "FASTA" to dropdown 'File format' of modal window 'Save Structure'
  • In case of multiple types sequences on canvas, error "Error during sequence type recognition(RNA, DNA or Peptide)" should appear

Content types for FASTA:

chemical/x-rna-fasta, chemical/x-dna-fasta, chemical/x-peptide-fasta

TBD
@olganaz olganaz added this to the Ketcher 2.20.0-rc.1 milestone Feb 23, 2024
@olganaz olganaz changed the title UI for Open/Save As FASTA Macro: UI for Open/Save As FASTA Mar 1, 2024
ilya-asiyuk-epam added a commit that referenced this issue Mar 13, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
4e6f7aa
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Mar 13, 2024 that will close this issue
#4146 - Macro: UI for Open/Save As FASTA #4240
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Mar 13, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
8f89f0f
ilya-asiyuk-epam added a commit that referenced this issue Mar 13, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
0c71ae3
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
118b831
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
e84a0bd
@Zhirnoff
Copy link
Collaborator

Tests added to the automation table.

ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
555f2e6
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
57a9dc6
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
eebc37b
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
711cc78
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
76d4439
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
0b45c52
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
acd7495
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
7f0ebff
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
44495ef
ilya-asiyuk-epam added a commit that referenced this issue Mar 14, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
0700fb3
ilya-asiyuk-epam added a commit that referenced this issue Mar 15, 2024
@ilya-asiyuk-epam
#4146 - Macro: UI for Open/Save As FASTA
eac45d8
ilya-asiyuk-epam added a commit that referenced this issue Mar 15, 2024
@ilya-asiyuk-epam
Merge pull request #4240 from epam/4146-macro-ui-for-open-save-as-fasta
48f5f0d 
#4146 - Macro: UI for Open/Save As FASTA
@NadezhdaPeskun NadezhdaPeskun mentioned this issue Mar 15, 2024
Closed
@Zhirnoff
Copy link
Collaborator

Tested. No comments.

This was referenced Mar 18, 2024
Closed
Closed
Closed
Open
Closed
This was referenced Mar 19, 2024
Open
Open
This was referenced Mar 21, 2024
Closed
Open
@AlexeyGirin AlexeyGirin mentioned this issue Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
feature request
Projects
None yet
Milestone
Ketcher 2.20.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4146 - Macro: UI for Open/Save As FASTA epam/ketcher
4 participants
@Zhirnoff @Andrey-Antonov @olganaz @ilya-asiyuk-epam