Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Maximum call stack size exceeded error appears during snake layout for large chains #4231

Closed
rrodionov91 opened this issue Mar 12, 2024 · 2 comments · Fixed by #4242
Closed

Macro: Maximum call stack size exceeded error appears during snake layout for large chains #4231

rrodionov91 opened this issue Mar 12, 2024 · 2 comments · Fixed by #4242
Assignees
@rrodionov91
Labels
bug Priority: High
Milestone
Ketcher 2.20.0-rc.1

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Mar 12, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode
  2. Open chain with 2000 or more rna items
  3. Turn on snake mode

Actual behavior
Uncaught RangeError: Maximum call stack size exceeded appeared in console. Chain layout did not changed.

Expected behavior
There is no errors in console. Chain changed layout to snake.
@rrodionov91 rrodionov91 added this to the Ketcher 2.20.0-rc.1 milestone Mar 12, 2024
@rrodionov91 rrodionov91 self-assigned this Mar 13, 2024
rrodionov91 added a commit that referenced this issue Mar 13, 2024
@rrodionov91
#4231 - Macro: Maximum call stack size exceeded error appears during …
d964f85 
…snake layout for large chains

- replaced recursion with stack implementation
@rrodionov91 rrodionov91 linked a pull request Mar 13, 2024 that will close this issue
#4231 - Macro: Maximum call stack size exceeded error appears during snake layout for large chains #4242
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator

Tests added to the automation table.

rrodionov91 added a commit that referenced this issue Mar 14, 2024
@rrodionov91
#4231 - Macro: Maximum call stack size exceeded error appears during …
714ea29 
…snake layout for large chains (#4242)

- replaced recursion with stack implementation

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Tested. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.20.0-rc.1
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff