Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Cyclic chains disappear from canvas when switching to sequence mode #4329

Closed
Zhirnoff opened this issue Mar 23, 2024 · 2 comments · Fixed by #4426 or #4551
Closed

Macro: Cyclic chains disappear from canvas when switching to sequence mode #4329

Zhirnoff opened this issue Mar 23, 2024 · 2 comments · Fixed by #4426 or #4551
Assignees
@baranovdv
Labels
bug Macromolecules Priority: High
Milestone
Ketcher 2.20.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Mar 23, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode
  2. Add RNA or DNA to canvas
  3. Make chain cyclic by connecting sugars through R2-R1 attachment points,
  4. Switch to sequence mode

Actual behavior
Cyclic chains disappear from canvas when switching to sequence mode

Expected behavior
Cyclic chains not disappear from canvas when switching to sequence mode.
Additional link should be visible.
image

Screenshots

2024-03-23_11h35_50.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.20.0-rc.1]
@Zhirnoff Zhirnoff added this to the Waiting for triage milestone Mar 23, 2024
baranovdv added a commit that referenced this issue Apr 5, 2024
@baranovdv
#4329 - Macro: Cyclic chains disappear from canvas when switching to …
3a13288 
…sequence mode

- add function that handles cycled chains
@baranovdv baranovdv linked a pull request Apr 5, 2024 that will close this issue
#4329 - Macro: Cyclic chains disappear from canvas when switching to sequence mode #4426
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Apr 25, 2024
@baranovdv
#4329 - Macro: Cyclic chains disappear from canvas when switching to …
2a69be5 
…sequence mode (#4426)

#4329 - Macro: Cyclic chains disappear from canvas when switching to sequence mode
@AlexeyGirin
Copy link
Collaborator

Fixed.
image
Ketcher Version 2.20.0-rc.3 Build at 2024-04-26; 16:57:15
Indigo Toolkit Version 1.19.0-rc.3.0-gf2d7689b8-wasm32-wasm-clang-12.0.0

OS: Windows 10
Browser Chrome Version 112.0.5615.138 (Official Build) (64-bit)

baranovdv added a commit that referenced this issue Apr 29, 2024
@baranovdv
- backmerge #4329 - Macro: Cyclic chains disappear from canvas when s…
24f886d 
…witching to sequence mode from release/2.20
@baranovdv baranovdv mentioned this issue Apr 29, 2024
Merged
9 tasks
@baranovdv baranovdv linked a pull request Apr 29, 2024 that will close this issue
Backmerge: #4329 macro cyclic chains disappear from canvas when switching to sequence mode #4551
Merged
9 tasks
@NadezhdaPeskun NadezhdaPeskun mentioned this issue Apr 30, 2024
Closed
rrodionov91 pushed a commit that referenced this issue May 10, 2024
@baranovdv @rrodionov91
#4329 - Macro: Cyclic chains disappear from canvas when switching to …
cfbface 
…sequence mode
@rrodionov91 rrodionov91 mentioned this issue May 10, 2024
Merged
9 tasks
@rrodionov91
Copy link
Collaborator

NataliaLoginova pushed a commit that referenced this issue May 10, 2024
@baranovdv
Backmerge: #4329 macro cyclic chains disappear from canvas when switc…
66e8733 
…hing to sequence mode (#4551)

* - backmerge #4329 - Macro: Cyclic chains disappear from canvas when switching to sequence mode from release/2.20

* - fix cycled linker draw in sequence mode

* -fix fillSubChains for linker

* -fix incorrect bonds render

* - feat update cycled linker screenshot

* -fix removed test

* -fix unnecessary monomer type check in fillSubChains method
rrodionov91 added a commit that referenced this issue May 10, 2024
@rrodionov91 @baranovdv
Backmerge: #4329 macro cyclic chains disappear from canvas when switc…
5f3688e 
…hing to sequence mode (#4606)

Co-authored-by: Dmitry Baranov <baranov.d.v.1988@gmail.com>
rrodionov91 pushed a commit that referenced this issue May 10, 2024
@baranovdv @rrodionov91
#4329 - Macro: Cyclic chains disappear from canvas when switching to …
653e79a 
…sequence mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baranovdv baranovdv

Labels
bug Macromolecules Priority: High
Projects
None yet
Milestone
Ketcher 2.20.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @baranovdv