Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Display IDT aliases in monomer library #4380

Closed
olganaz opened this issue Apr 1, 2024 · 5 comments · Fixed by #4591
Closed

Macro: Display IDT aliases in monomer library #4380

olganaz opened this issue Apr 1, 2024 · 5 comments · Fixed by #4591
Assignees
@DmitriiP-EPAM
Labels
feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.22.0-rc.2

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 1, 2024 •
edited by Andrey-Antonov
Loading

IDT aliases, where defined, should be displayed in the preview window for RNA monomers, CHEMs and presets in monomer library.

Same elements on canvas are out of scope.

UX
image
@olganaz olganaz added this to the Ketcher 2.22.0-rc.1 milestone Apr 1, 2024
@olganaz olganaz added the IDT Bucket: IDT related issues label Apr 5, 2024
@vanoprenko vanoprenko changed the title Macro: Display IDT alias in Ketcher UX Macro: Display IDT aliases in monomer library Apr 8, 2024
@Zhirnoff
Copy link
Collaborator

Test added to the automation table.

@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 6, 2024
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4380 - Feature (MonomerWithIDTAliasesPreview): Create the component
ca6d8f9
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4380 - Feature (Preview): Use MonomerWithIDTAliasesPreview
69220f4
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4380 - Refactor (MonomerWithIDTAliasesPreview): Delete the useless f…
d2f33da 
…ragments
@DmitriiP-EPAM DmitriiP-EPAM linked a pull request May 8, 2024 that will close this issue
#4380 – Macro: Display IDT aliases in monomer library #4591
Merged
9 tasks
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4380 - Refactor (IDTAliases.tsx): Apply the code style
c20b0e7
DmitriiP-EPAM added a commit that referenced this issue May 8, 2024
@DmitriiP-EPAM
#4380 - Bugfix (MonomerWithIDTAliasesPreview): Recover className
cf1cf0a
@NataliaLoginova
Copy link
Collaborator

IDT has to be taken from field idtAliases in monomers.ket
image
Everything that is in the modifications field should be displayed, or if there are no modification field, then display the base field.

@NataliaLoginova
Copy link
Collaborator

Preview has to be added for Presets in RNA.
It should look like Preview in canvas in sequence mode.
image

DmitriiP-EPAM added a commit that referenced this issue May 13, 2024
@DmitriiP-EPAM
#4380 - Draft (RnaPresetGroup.tsx): Use events from MonomerItem
be563e3
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Refactor (RnaPresetGroup.tsx): Create `calculateMonomerPrevie…
3297eda 
…wTop(1)` and `calculateNucleosideOrNucleotidePreviewTop(1)`
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Feature (RnaPresetGroup.tsx): Show the preview for presets
07da0a4
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Refactor (RnaPresetGroup.tsx): Specify the type
2b41481
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Feature (MonomerWithIDTAliasesPreview): Create the component
cdc4951
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Feature (Preview): Use MonomerWithIDTAliasesPreview
ba22778
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Refactor (MonomerWithIDTAliasesPreview): Delete the useless f…
7e114ec 
…ragments
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Refactor (IDTAliases.tsx): Apply the code style
991d22c
DmitriiP-EPAM added a commit that referenced this issue May 14, 2024
@DmitriiP-EPAM
#4380 - Bugfix (MonomerWithIDTAliasesPreview): Recover className
a3e15d1
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (Editor.tsx): Refactor handleOpenPreview
9932ef5
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (editorSlice.ts): Specify EditorState
9132623
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (calculatePreviewTop.ts): Rename the file
bc5ebe4
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Build (ketcher-autotests): Run npm install
7a96632
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (editorSlice.ts): Add the TODO
1c0498a
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Style (NucleotidePreview): Change the positioning, handle `tr…
07c602a 
…ansform`
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (Preview): Specify the types
440fee7
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Test (Sequence-mode-selection-for-view-mode-Select-letters-wi…
37c1933 
…th-Shift-Lclick-1-chromium-linux.png): Update the snapshot
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (calculatePreviewTop.ts): Update the main function
20aa6e4
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (MonomerWithIDTAliasesPreview): Optimize the conditions
273151a
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Bugfix (Editor.tsx): Correct the positioning
3c79894
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (PresetPreview): Rename the component
11b9547
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor (editorSlice.ts): Specify the types for preset
3c24cf9
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Test (Macromolecule-editor): Update the snapshots
17b46c2
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (getDefaultPreset.ts): Update getDefaultPresets(2)
133d7ce
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
Revert "#4380 - Refactor (calculatePreviewTop.ts): Update the main fu…
383751f 
…nction"

This reverts commit 22664e6.
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
Revert "Revert "#4380 - Refactor (calculatePreviewTop.ts): Update the…
bbb83f6 
… main function""

This reverts commit 2a33631.
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (PresetPreview): Show IDT aliases
50b8a6d
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (RnaPresetGroup.tsx): Set preset.idtAliases
a751cfd
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (MonomerWithIDTAliasesPreview): Change the styles
3c6c8ed
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (MonomerWithIDTAliasesPreview): Change the styles (co…
fe33178 
…lor, font-size)
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (MonomerWithIDTAliasesPreview): Change the styles (co…
30eafeb 
…lor, font-size) (amend)
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Feature (MonomerWithIDTAliasesPreview): Change the styles (fo…
2429de8 
…nt-weight, line-height)
svvald pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM @svvald
#4380 - Refactor: Create the file to update the reports
e40ad54
svvald added a commit that referenced this issue May 31, 2024
@svvald
#4380 – update UI tests
ed861a1
svvald added a commit that referenced this issue May 31, 2024
@svvald
#4380 – update UI tests after failure
24fcea2
rrodionov91 pushed a commit that referenced this issue May 31, 2024
@DmitriiP-EPAM
#4380 – Macro: Display IDT aliases in monomer library (#4591)
a30214c
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 5, 2024

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]

@AlexeyGirin AlexeyGirin mentioned this issue Jun 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DmitriiP-EPAM DmitriiP-EPAM

Labels
feature request IDT Bucket: IDT related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.22.0-rc.2
Development

Successfully merging a pull request may close this issue.

#4380 – Macro: Display IDT aliases in monomer library epam/ketcher
6 participants
@NataliaLoginova @AlexeyGirin @Zhirnoff @Andrey-Antonov @olganaz @DmitriiP-EPAM