Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Different chains shown by the same sequence in sequence mode (system ignores sugar presence) #4399

Closed
AlexeyGirin opened this issue Apr 3, 2024 · 3 comments · Fixed by #4574 or #4681
Closed

Preview: Different chains shown by the same sequence in sequence mode (system ignores sugar presence) #4399

AlexeyGirin opened this issue Apr 3, 2024 · 3 comments · Fixed by #4574 or #4681
Assignees
@baranovdv
Labels
bug Macromolecules Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.21.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Apr 3, 2024 •
edited by olganaz
Loading

Steps to Reproduce

  1. Switch to Macro
  2. Load from file: Different chains show by the same sequence in sequence mode (system ignores sugar presence).zip
  3. Switch to Sequence mode
    image

Actual behavior
Different chains shown by the same sequence
image

Expected behavior

  • Nucleotide without phosphate = nucleoSide
  • NucleoSide in the middle of the chain should be marked similar to nucleotide with modified phosphate (up-right circle), but with white fill.
  • Last nucleoSide shouldn't be marked.

See mockup
image

Approved by @AlexanderSavelyev and @vanoprenko

Versions:
Windows 10
Chrome Version 112.0.5615.138 (Official Build) (64-bit)
Ketcher Version 2.20.0-rc.2 Build at 2024-04-02; 05:31:05
Indigo Toolkit Version 1.20.0-dev.1.19-gd0224f91-wasm32-wasm-clang-12.0.0

Issue found in the context of testing - #3734
@AlexeyGirin AlexeyGirin mentioned this issue Apr 8, 2024
Closed
@AlexeyGirin
Copy link
Collaborator Author

@olganaz please document decision somewhere

@olganaz olganaz removed their assignment Apr 12, 2024
@olganaz
Copy link
Collaborator

olganaz commented Apr 12, 2024

Updated expected behavior, added mockup.

@AlexeyGirin AlexeyGirin added the Sequence mode Bucket: Sequence mode related issues label Apr 17, 2024
@baranovdv baranovdv self-assigned this May 3, 2024
baranovdv added a commit that referenced this issue May 6, 2024
@baranovdv
#4399 - Different chains shown by the same sequence in sequence mode …
e3d6edf 
…(system ignores sugar presence)
@baranovdv baranovdv linked a pull request May 6, 2024 that will close this issue
#4399 - Different chains shown by the same sequence in sequence mode (system ignores sugar presence) #4574
Merged
9 tasks
@AlexeyGirin AlexeyGirin changed the title Different chains shown by the same sequence in sequence mode (system ignores sugar presence) Preview: Different chains shown by the same sequence in sequence mode (system ignores sugar presence) May 15, 2024
rrodionov91 pushed a commit that referenced this issue May 17, 2024
@baranovdv @rrodionov91
#4399 - Different chains shown by the same sequence in sequence mode …
d3e5599 
…(system ignores sugar presence)
rrodionov91 pushed a commit that referenced this issue May 17, 2024
@baranovdv
#4399 - Different chains shown by the same sequence in sequence mode …
dbd055f 
…(system ignores sugar presence) (#4574)
@baranovdv baranovdv linked a pull request May 17, 2024 that will close this issue
Backmerge: #4399 - Different chains shown by the same sequence in sequence mode (system ignores sugar presence) #4644
Closed
9 tasks
baranovdv added a commit that referenced this issue May 23, 2024
@baranovdv
- backmerge #4399 - Different chains shown by the same sequence in se…
e3db0c2 
…quence mode (system ignores sugar presence)
rrodionov91 pushed a commit that referenced this issue May 27, 2024
@baranovdv @rrodionov91
- backmerge #4399 - Different chains shown by the same sequence in se…
83e5995 
…quence mode (system ignores sugar presence)
rrodionov91 pushed a commit that referenced this issue May 29, 2024
@baranovdv @rrodionov91
- backmerge #4399 - Different chains shown by the same sequence in se…
4263cd4 
…quence mode (system ignores sugar presence)
@rrodionov91 rrodionov91 linked a pull request May 30, 2024 that will close this issue
Backmerge: #4399 - Different chains shown by the same sequence in sequence mode (system ignores sugar presence) #4681
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue May 30, 2024
@baranovdv
Backmerge: #4399 - Different chains shown by the same sequence in seq…
a5a1fc3 
…uence mode (system ignores sugar presence) (#4681)
vitaepam added a commit that referenced this issue May 30, 2024
@vitaepam
Squashed commit of the following:
6f302d3 
commit a5a1fc3
Author: Dmitry Baranov <baranov.d.v.1988@gmail.com>
Date:   Thu May 30 15:58:32 2024 +0500

    Backmerge: #4399 - Different chains shown by the same sequence in sequence mode (system ignores sugar presence) (#4681)

commit 01b189e
Author: Mikhail Zhirnov <62464241+Zhirnoff@users.noreply.github.com>
Date:   Thu May 30 11:53:41 2024 +0300

    Autotests: #4668 - api tests (#4673)

    * - added tests to 'API';
    - added functions to 'format.ts'

    * - added tests;
    - added expected snapshots

    * - added tests;
    - added expected snapshots

    * - updated files and screenshots

    * - added tests;
    - added 1 test file;
    - added expected snapshots

    * - added tests;
    - added expected snapshots

    * - updated snapshots

    * - added tests;
    - added expected snapshots

    * - updated playwright version

    * - added tests;
    - added expected snapshots

commit c4042b5
Author: Alexey Girin <agirin@mail.ru>
Date:   Thu May 30 10:35:40 2024 +0300

    Autotests: #4422 - GUI tests (#4691)

    * 4422 - GUI tests (test and screenshots)

    * 4422 - more GUI tests

    * Final version

    * Minor corrections

    * More fixes

    * more fixes2

    * More fixes

    * more fixes 2

    * More fixes 3

    * More fixes 4

    * #4422 - broken tests and some flacky are fixed

    * MOde fixes

    * and more

    * More fixes

    * One more fix

    * More fixes

commit a00bf26
Author: Ruslan <117785539+Guch1g0v@users.noreply.github.com>
Date:   Thu May 30 02:00:38 2024 +0500

commit 1e7c398
Author: Alexey Girin <agirin@mail.ru>
Date:   Wed May 29 11:43:07 2024 +0300

    Bump request: Update playwright.yml (#4707)

    temporary rise execution time for microtests

    [skip ci]

commit d15aa1d
Merge: b7b81e1 5c30180
Author: Ilya Asiyuk <156656634+ilya-asiyuk-epam@users.noreply.github.com>
Date:   Wed May 29 10:23:48 2024 +0400

    Merge pull request #4699 from epam/4697-macro-highlight-connection-point-change-mouse-cursor-on-mouse-hover

commit b7b81e1
Author: Alexey Girin <agirin@mail.ru>
Date:   Tue May 28 23:28:00 2024 +0300

commit af5d024
Merge: 52ace78 66d6d0b
Author: Ilya Asiyuk <156656634+ilya-asiyuk-epam@users.noreply.github.com>
Date:   Tue May 28 15:07:24 2024 +0400

    Merge pull request #4696 from epam/4692-macro-cursors-should-be-copied-from-small-mode

commit 5c30180
Author: Ilya Asiyuk <ilya_asiyuk@epam.com>
Date:   Tue May 28 12:37:03 2024 +0400

commit 66d6d0b
Author: Ilya Asiyuk <ilya_asiyuk@epam.com>
Date:   Mon May 27 15:29:14 2024 +0400
vitaepam added a commit that referenced this issue May 30, 2024
@vitaepam
Squashed commit of the following:
657c3dc 
commit a5a1fc3
Author: Dmitry Baranov <baranov.d.v.1988@gmail.com>
Date:   Thu May 30 15:58:32 2024 +0500

    Backmerge: #4399 - Different chains shown by the same sequence in sequence mode (system ignores sugar presence) (#4681)

commit 01b189e
Author: Mikhail Zhirnov <62464241+Zhirnoff@users.noreply.github.com>
Date:   Thu May 30 11:53:41 2024 +0300

    Autotests: #4668 - api tests (#4673)

    * - added tests to 'API';
    - added functions to 'format.ts'

    * - added tests;
    - added expected snapshots

    * - added tests;
    - added expected snapshots

    * - updated files and screenshots

    * - added tests;
    - added 1 test file;
    - added expected snapshots

    * - added tests;
    - added expected snapshots

    * - updated snapshots

    * - added tests;
    - added expected snapshots

    * - updated playwright version

    * - added tests;
    - added expected snapshots

commit c4042b5
Author: Alexey Girin <agirin@mail.ru>
Date:   Thu May 30 10:35:40 2024 +0300

    Autotests: #4422 - GUI tests (#4691)

    * 4422 - GUI tests (test and screenshots)

    * 4422 - more GUI tests

    * Final version

    * Minor corrections

    * More fixes

    * more fixes2

    * More fixes

    * more fixes 2

    * More fixes 3

    * More fixes 4

    * #4422 - broken tests and some flacky are fixed

    * MOde fixes

    * and more

    * More fixes

    * One more fix

    * More fixes

commit a00bf26
Author: Ruslan <117785539+Guch1g0v@users.noreply.github.com>
Date:   Thu May 30 02:00:38 2024 +0500

commit 1e7c398
Author: Alexey Girin <agirin@mail.ru>
Date:   Wed May 29 11:43:07 2024 +0300

    Bump request: Update playwright.yml (#4707)

    temporary rise execution time for microtests

    [skip ci]

commit d15aa1d
Merge: b7b81e1 5c30180
Author: Ilya Asiyuk <156656634+ilya-asiyuk-epam@users.noreply.github.com>
Date:   Wed May 29 10:23:48 2024 +0400

    Merge pull request #4699 from epam/4697-macro-highlight-connection-point-change-mouse-cursor-on-mouse-hover

commit b7b81e1
Author: Alexey Girin <agirin@mail.ru>
Date:   Tue May 28 23:28:00 2024 +0300

commit af5d024
Merge: 52ace78 66d6d0b
Author: Ilya Asiyuk <156656634+ilya-asiyuk-epam@users.noreply.github.com>
Date:   Tue May 28 15:07:24 2024 +0400

    Merge pull request #4696 from epam/4692-macro-cursors-should-be-copied-from-small-mode

commit 5c30180
Author: Ilya Asiyuk <ilya_asiyuk@epam.com>
Date:   Tue May 28 12:37:03 2024 +0400

commit 66d6d0b
Author: Ilya Asiyuk <ilya_asiyuk@epam.com>
Date:   Mon May 27 15:29:14 2024 +0400
@AlexeyGirin
Copy link
Collaborator Author

Verified.
Windows 10
Chrome Version 125.0.6422.113 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.2 Build at 2024-05-31; 10:48:44
Indigo Toolkit Version 1.21.0-dev.5.2-g994bdab98-x86_64-linux-gnu-11.2.1

image

@AlexeyGirin AlexeyGirin mentioned this issue Jun 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baranovdv baranovdv

Labels
bug Macromolecules Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.21.0-rc.3
6 participants
@vanoprenko @AlexeyGirin @vitaepam @baranovdv @olganaz @ilya-asiyuk-epam