Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Update sequence' modal window: display the number of nucleotides to be changed #4455

Closed
olganaz opened this issue Apr 11, 2024 · 1 comment · Fixed by #4457
Closed

'Update sequence' modal window: display the number of nucleotides to be changed #4455

olganaz opened this issue Apr 11, 2024 · 1 comment · Fixed by #4457
Assignees
@ilya-asiyuk-epam
Labels
bug
Milestone
Ketcher 2.21.0-rc.1

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 11, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to 'Macromolecules' -> Sequence mode
  2. Add any RNA sequence on canvas
  3. Select multiple nucleotides
  4. Rclick- -> modify in RNA builder --> select any phosphate or base or phosphate in RNA-builder
  5. Press 'Apply' -> "Update Sequence" modal window appears

Actual behavior
Notification: "You are going to make multiple changes in your sequence. Are you sure?" is displayed in modal window.

Expected behavior
Notification should be changed to: "You are going to modify N nucleotides. Are you sure?"
Where N - the number of nucleotides being modified

Screenshots
image

Desktop (please complete the following information):
OS: Windows 10
Browser Chrome
Version

Ketcher version
Version 2.19.0-rc.2
Build at 2024-04-09; 09:32:33
@olganaz olganaz added the bug label Apr 11, 2024
@olganaz olganaz added this to the Ketcher 2.21.0-rc.1 milestone Apr 11, 2024
@olganaz olganaz changed the title 'Update sequence' modal window: display the number of nucleotides to changed 'Update sequence' modal window: display the number of nucleotides to be changed Apr 11, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 12, 2024
ilya-asiyuk-epam added a commit that referenced this issue Apr 12, 2024
@ilya-asiyuk-epam
#4455 - 'Update sequence' modal window: display the number of nucleot…
f9598ee 
…ides to be changed
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Apr 12, 2024 that will close this issue
#4455 - 'Update sequence' modal window: display the number of nucleotides to be changed #4457
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Apr 12, 2024
@ilya-asiyuk-epam
#4455 - 'Update sequence' modal window: display the number of nucleot…
f8384a4 
…ides to be changed
rrodionov91 pushed a commit that referenced this issue Apr 12, 2024
@ilya-asiyuk-epam
#4455 - 'Update sequence' modal window: display the number of nucleot…
68e08fe 
…ides to be changed (#4457)
@AlexeyGirin
Copy link
Collaborator

Fixed.
image
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug
Projects
None yet
Milestone
Ketcher 2.21.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4455 - 'Update sequence' modal window: display the number of nucleotides to be changed epam/ketcher
3 participants
@AlexeyGirin @olganaz @ilya-asiyuk-epam