Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: RNA builder: Cancel button doesn't work #4487

Closed
AlexeyGirin opened this issue Apr 18, 2024 · 3 comments · Fixed by #4518
Closed

Macro: RNA builder: Cancel button doesn't work #4487

AlexeyGirin opened this issue Apr 18, 2024 · 3 comments · Fixed by #4518
Assignees
@ilya-asiyuk-epam
Labels
bug Macromolecules Priority: High RNA Builder Bucket: RNA builder related issues
Milestone
Ketcher 2.21.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Apr 18, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro
  2. Go to RNA tab
  3. Call Duplicate and edit from context menu for any preset
    image
  4. Press Cancel button

Actual behavior
Nothing happens
image

Expected behavior
System close new preset creation dialog
image

Versions:
Windows 10
Chrome Version Version 123.0.6312.106 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Issue found while testing #4483
@AlexeyGirin AlexeyGirin added bug Priority: Medium RNA Builder Bucket: RNA builder related issues labels Apr 18, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.21.0-rc.2 milestone Apr 18, 2024
@AlexeyGirin AlexeyGirin changed the title RNA builder: Cancel button doesn't work Macro: RNA builder: Cancel button doesn't work Apr 18, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 19, 2024
@ilya-asiyuk-epam
Copy link
Contributor

ilya-asiyuk-epam commented Apr 19, 2024 •
edited
Loading

I'll fix it.
TODO:
in RnaEditorExpanded
add below:
const onCancel = () => { if (isSequenceEditInRNABuilderMode) { resetAfterSequenceUpdate(); } else { setNewPreset(activePreset); dispatch(setIsEditMode(false)); dispatch(setActivePresetMonomerGroup(null)); } };

ilya-asiyuk-epam added a commit that referenced this issue Apr 23, 2024
@ilya-asiyuk-epam
#4487 - Macro: RNA builder: Cancel button doesn't work
fb8801e
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Apr 24, 2024 that will close this issue
#4487 - Macro: RNA builder: Cancel button doesn't work #4518
Merged
9 tasks
ilya-asiyuk-epam added a commit that referenced this issue Apr 24, 2024
@ilya-asiyuk-epam
Merge pull request #4518 from epam/4487-macro-rna-builder-cancel-butt…
42edac5 
…on-doesnot-work

#4487 - Macro: RNA builder: Cancel button doesn't work
@NadezhdaPeskun NadezhdaPeskun mentioned this issue Apr 26, 2024
Open
@NadezhdaPeskun
Copy link

NadezhdaPeskun commented Apr 26, 2024 •
edited
Loading

Verified as fixed except issue #4447
Verified on CI

@AlexeyGirin
Copy link
Collaborator Author

Verified.
Windows 10
Chrome Version Version 124.0.6367.119 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.2 Build at 2024-05-07; 12:32:44
Indigo Toolkit Version 1.20.0-rc.2.0-g111a89f35-wasm32-wasm-clang-12.0.0
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilya-asiyuk-epam ilya-asiyuk-epam

Labels
bug Macromolecules Priority: High RNA Builder Bucket: RNA builder related issues
Projects
None yet
Milestone
Ketcher 2.21.0-rc.2
Development

Successfully merging a pull request may close this issue.

#4487 - Macro: RNA builder: Cancel button doesn't work epam/ketcher
3 participants
@AlexeyGirin @ilya-asiyuk-epam @NadezhdaPeskun