Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow connection of molecule with monomer #4532

Closed
rrodionov91 opened this issue Apr 24, 2024 · 2 comments · Fixed by #4695 or #4727
Closed

Allow connection of molecule with monomer #4532

rrodionov91 opened this issue Apr 24, 2024 · 2 comments · Fixed by #4695 or #4727
Assignees
Labels
Test Cases Written Test cases has been written for that issue

Comments

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Apr 24, 2024

Background
Functionality of attachment points addition for molecules will be implemented in ticket: #4530
After that connections between molecules and monomers in macromolecules mode will be enabled. It needs to implement different serialization rules for such connections.

Solution

  1. Connections between molecules and monomers should be serialized/deserialized to ket with such structure:
// Connection
{
    "connectionType": "single",
    "endpoint1": {
        "monomerId": "monomer14",
        "attachmentPointId": "R2"
    },
    "endpoint2": {
        "moleculeId": "mol0",
        "atomId": "2"
    }
},
  1. Such connections should be displayed as connection between monomers in macromolecules mode and connection between sgroup and atom of molecule in molecules mode.

Macromolecules mode:
Screenshot 2024-05-27 at 19 15 09

Molecules mode:
Screenshot 2024-05-27 at 19 15 17

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented May 7, 2024

Rules of Center to Center connection? - Same as for CHEM

@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 7, 2024
@rrodionov91 rrodionov91 self-assigned this May 13, 2024
@rrodionov91 rrodionov91 linked a pull request May 27, 2024 that will close this issue
9 tasks
@rrodionov91 rrodionov91 removed the Test Cases Written Test cases has been written for that issue label May 29, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 31, 2024
@rrodionov91 rrodionov91 linked a pull request Jun 1, 2024 that will close this issue
9 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 4, 2024

Tested.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Cases Written Test cases has been written for that issue
Projects
None yet
3 participants