#4530 - Add ability to define attachment points for molecules fixes #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed atomId in molecule-monomer connections in serialization - turned off structure rescaling during opening from file if there is monomer-molecule connection
auto-assign
bot
requested review from
AlexeyGirin,
ilya-asiyuk-epam and
StarlaStarla
This was
linked to
issues
Jun 1, 2024
rrodionov91
changed the title
svvald
approved these changes
Jun 3, 2024
| @@ -149,6 +150,14 @@ export function load(struct: Struct, options?) { | |||
| const hasUnsupportedGroups = parsedStruct.sgroups.some( | |||
| (sGroup) => !supportedSGroupTypes[sGroup.type], | |||
| ); | |||
| const hasMoleculeToMonomerConnections = parsedStruct.bonds.find( | |||
There was a problem hiding this comment.
It's minor, but it seems that .some might fit better semantically here rather than .find as you return some flag of whether any bond meets your condition, not the bond itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name