Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Having attachment points on the canvas causes crash while switching to Micro-Macro and back #4617

Closed
AlexeyGirin opened this issue May 13, 2024 · 1 comment · Fixed by #4695
Closed

Preview: Having attachment points on the canvas causes crash while switching to Micro-Macro and back #4617

AlexeyGirin opened this issue May 13, 2024 · 1 comment · Fixed by #4695
Assignees
@tmrr13
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Milestone
Ketcher 2.22.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: All possible Rx2.zip
  2. Switch to Macro
  3. Switch to Micro

Actual behavior
Application crashes
image
ci.test.lifescience.opensource.epam.com-1715610238435.log

Expected behavior
No crash

Versions [e.g. v2.4.2].

  • Indigo Toolkit Version 1.20.0-dev.1.32-gf28bad61-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-13; 05:32:02
  • Chrome Version 124.0.6367.201 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added bug Priority: High Macromolecules Macro-Micro Bucket: Macro-Micro View related issues labels May 13, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.1 milestone May 13, 2024
@tmrr13 tmrr13 self-assigned this May 15, 2024
@AlexeyGirin AlexeyGirin changed the title Having attachment points on the canvas causes crash while switching to Micro-Macro and back Preview: Having attachment points on the canvas causes crash while switching to Micro-Macro and back May 15, 2024
tmrr13 added a commit that referenced this issue May 16, 2024
@tmrr13
#4617 - Preview: Having attachment points on the canvas causes crash …
eded0e7 
…while switching to Micro-Macro and back
@tmrr13 tmrr13 linked a pull request May 16, 2024 that will close this issue
#4617 - Preview: Having attachment points on the canvas causes crash while switching to Micro-Macro and back #4633
Closed
9 tasks
tmrr13 added a commit that referenced this issue May 24, 2024
@tmrr13
#4617 - Preview: Having attachment points on the canvas causes crash …
6a92775 
…while switching to Micro-Macro and back
@rrodionov91 rrodionov91 linked a pull request Jun 3, 2024 that will close this issue
#4530 - Add ability to define attachment points for molecules #4695
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmrr13 tmrr13

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.22.0-rc.2
3 participants
@rrodionov91 @tmrr13 @AlexeyGirin