Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero charge shows explicit 0 instead of blank after using A+/A- Tools #4660

Closed
Zhirnoff opened this issue May 20, 2024 · 2 comments · Fixed by #4752, #4968 or #5018
Closed

Zero charge shows explicit 0 instead of blank after using A+/A- Tools #4660

Zhirnoff opened this issue May 20, 2024 · 2 comments · Fixed by #4752, #4968 or #5018
Assignees
@Guch1g0v
Labels
bug Priority: High User's Feedback
Milestone
Ketcher 2.23.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented May 20, 2024 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add any atom on canvas
  3. Select Charge plus (A+) and click on atom
  4. Select Charge minus (A-) and click on atom

Actual behavior
Zero charge shows explicit 0 instead of blank after using A+/A- Tools

Expected behavior
Zero charge shows blank after using A+/A- Tools

Screenshots

2024-05-20_13h41_41.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.2]

#187636068
@Zhirnoff Zhirnoff added this to the Ketcher 2.23.0-rc.1 milestone May 20, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 5, 2024
Guch1g0v added a commit that referenced this issue Jun 5, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
9700098 
…A- Tools
@Guch1g0v Guch1g0v linked a pull request Jun 5, 2024 that will close this issue
#4660 - Zero charge shows explicit 0 instead of blank after using A+/A- Tools #4752
Merged
9 tasks
Guch1g0v added a commit that referenced this issue Jun 6, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
30513da 
…A- Tools (#4752)
@AnnaKosol
Copy link
Contributor

AnnaKosol commented Jul 2, 2024 •
edited
Loading

Actual behavior
Zero charge shows explicit 0 instead of blank after using A+/A- Tools

2024-07-02.14.26.54.mov

Expected behavior
Zero charge shows blank after using A+/A- Tools

Versions:
Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 09:03:38
Indigo Version 1.21.0-rc.1.0-g9194599b2-x86_64-linux-gnu-11.2.1
MacOs Sonoma version 14.5
Chrome Version 126.0.6478.127 (Официальная сборка), (arm64)

@AnnaKosol AnnaKosol reopened this Jul 2, 2024
Guch1g0v added a commit that referenced this issue Jul 2, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
d53a79b 
…A- Tools - 2.23
@Guch1g0v Guch1g0v linked a pull request Jul 2, 2024 that will close this issue
#4660 - Zero charge shows explicit 0 instead of blank after using A+/A- Tools #4968
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
b4c0c9a 
…A- Tools - 2.23 (#4968)
Guch1g0v added a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
18913d7 
…A- Tools - 2.23 (#4968)
@Guch1g0v Guch1g0v linked a pull request Jul 5, 2024 that will close this issue
Backmerge: #4660 - Zero charge shows explicit 0 instead of blank after using A+/A- Tools #5018
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jul 6, 2024
@Guch1g0v
#4660 - Zero charge shows explicit 0 instead of blank after using A+/…
bd2a407 
…A- Tools - 2.23 (#4968) (#5018)
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-07-11_14h56_51

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.2]
Indigo version
[Version 1.22.0-rc.2]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Priority: High User's Feedback
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.23.0-rc.2
3 participants
@Zhirnoff @Guch1g0v @AnnaKosol