Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong sequence if sequence with cycle is saved to FASTA or Sequence file. #4679

Closed
NadezhdaPeskun opened this issue May 22, 2024 · 2 comments

Comments

@NadezhdaPeskun
Copy link

NadezhdaPeskun commented May 22, 2024

Steps to Reproduce

  1. Switch to Macro

  2. Open file
    ketcher (modify (1)).zip

  3. Try to save to FASTA of Sequence file

Actual behavior
Wrong sequence (GCG) is saved to FASTA or Sequence file instead of GGC.
wrong sequence

wrong sequence2

Expected behavior
Sequence should be GGC as on the Canvas

please see

Versions:
Windows 11
Chrome Version Version 123.0.6312.106 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

@NadezhdaPeskun NadezhdaPeskun added this to the Ketcher 2.22.0-rc.1 milestone May 22, 2024
@NadezhdaPeskun NadezhdaPeskun changed the title Wrong sequence is saved to FASTA or Sequence file. Wrong sequence is saved sequence with cycle to FASTA or Sequence file. May 23, 2024
@NadezhdaPeskun NadezhdaPeskun changed the title Wrong sequence is saved sequence with cycle to FASTA or Sequence file. Wrong sequence if sequence with cycle is saved to FASTA or Sequence file. May 23, 2024
@Guch1g0v Guch1g0v removed their assignment May 30, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 28, 2024
@Guch1g0v
Copy link
Collaborator

Guch1g0v commented Jun 29, 2024

Fasta and sequence converts by indigo, we also need to decide whether it is necessary to somehow select the first element in the case of a cyclic sequence, if necessary, then in what way?

@AlexeyGirin
Copy link
Collaborator

MOved to indigo - epam/Indigo#2042

@AlexeyGirin AlexeyGirin closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2024
@AlexeyGirin AlexeyGirin removed this from the Ketcher 2.23.0-rc.1 milestone Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants