Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo problem while layout is changed on the Snack of Flex modes and switch through modes. #4690

Closed
NadezhdaPeskun opened this issue May 24, 2024 · 1 comment · Fixed by #4748 or #4753
Closed

Undo problem while layout is changed on the Snack of Flex modes and switch through modes. #4690

NadezhdaPeskun opened this issue May 24, 2024 · 1 comment · Fixed by #4748 or #4753
Assignees
@rrodionov91
Labels
bug Priority: High
Milestone
Ketcher 2.22.0-rc.3

Comments

@NadezhdaPeskun
Copy link

NadezhdaPeskun commented May 24, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro
  2. go to Sequence mode
  3. Open File
    ketcher (51).zip
  4. Snack of Flex modes
  5. change layout of cycling second sequence
  6. Switch to Sequence mode

Actual behavior
Undo problem while layout is changed on the Snack of Flex modes and switch through modes.
Several steps of UNDU actions have broken peptide Bonds or Bonds are lost.
Kindly see video file.

2024-05-24_17h38_34.mp4

Expected behavior
Undo should correspond Redo actions without broken bonds.

Possible related with

Versions:
Version 2.21.0-rc.1
Build at 2024-04-29; 09:29:15

Indigo Toolkit
Version 1.20.0-rc.1.0-g8e8ffc3c3-x86_64-linux-gnu-11.2.1
@NadezhdaPeskun NadezhdaPeskun added this to the Ketcher 2.22.0-rc.1 milestone May 24, 2024
This was referenced May 24, 2024
Closed
Closed
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4690 - Undo problem while layout is changed on the Snack of Flex mod…
7175d1e 
…es and switch through modes

- prevented layout to be called if turn on snake mode by undo operation
- changed move to redraw for polymerBonds in DrawingEntityMoveOperation
@rrodionov91 rrodionov91 linked a pull request Jun 4, 2024 that will close this issue
#4690 - Undo problem while layout is changed on the Snack of Flex modes and switch through modes #4748
Merged
9 tasks
@rrodionov91 rrodionov91 self-assigned this Jun 4, 2024
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4690 - Undo problem while layout is changed on the Snack of Flex mod…
2cc3c1e 
…es and switch through modes

- prevented layout to be called if turn on snake mode by undo operation
- changed move to redraw for polymerBonds in DrawingEntityMoveOperation
@rrodionov91 rrodionov91 linked a pull request Jun 5, 2024 that will close this issue
Backmerge: #4690 - Undo problem while layout is changed on the Snack of Flex modes and switch through modes #4753
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4690 - Undo problem while layout is changed on the Snack of Flex mod…
1d6d960 
…es and switch through modes (#4748)

* #4690 - Undo problem while layout is changed on the Snack of Flex modes and switch through modes

- prevented layout to be called if turn on snake mode by undo operation
- changed move to redraw for polymerBonds in DrawingEntityMoveOperation

* #4333 - Macro: Bonds detach when moving monomers in a snake mode in Playwright autotests

- updated screenshots
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
Backmerge: #4690 - Undo problem while layout is changed on the Snack …
6b0221d 
…of Flex modes and switch through modes (#4753)

* #4690 - Undo problem while layout is changed on the Snack of Flex modes and switch through modes

- prevented layout to be called if turn on snake mode by undo operation
- changed move to redraw for polymerBonds in DrawingEntityMoveOperation

* #4333 - Macro: Bonds detach when moving monomers in a snake mode in Playwright autotests

- updated screenshots
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.3 Build at 2024-06-10; 12:34:49
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

@AlexeyGirin AlexeyGirin mentioned this issue Jun 29, 2024
Closed
@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.22.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @NadezhdaPeskun @DmitriiP-EPAM