Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Monomers from macro mode are not erased by Erase tool in micro mode #4734

Closed
Zhirnoff opened this issue Jun 3, 2024 · 1 comment · Fixed by #4737 or #4743
Closed

Preview: Monomers from macro mode are not erased by Erase tool in micro mode #4734

Zhirnoff opened this issue Jun 3, 2024 · 1 comment · Fixed by #4737 or #4743
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Milestone
Ketcher 2.22.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 3, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode
  2. Add any monomer on canvas
  3. Switch to Micro mode
  4. Select Erase tool and click on monomer abbreviation

Actual behavior
Monomers from macro mode are not erased by Erase tool in micro mode
Note: If we delete monomer by 'Delete' hotkey we have many errors in DevTool Console
2024-06-04_13h38_54

Expected behavior
Monomers from macro mode are erased by Erase tool in micro mode
And can be deletet by 'Delete' hotkey.
Screenshots

2024-06-03_17h52_34.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.21.0-rc.2] Local build from master branch
@Zhirnoff Zhirnoff added bug Priority: High Macromolecules Macro-Micro Bucket: Macro-Micro View related issues labels Jun 3, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.22.0-rc.3 milestone Jun 3, 2024
rrodionov91 added a commit that referenced this issue Jun 3, 2024
@rrodionov91
#4734 - Preview: Monomers from macro mode are not erased by Erase too…
ba57a12 
…l in micro mode

- unblocked monomers deletion in micro mode
@rrodionov91 rrodionov91 linked a pull request Jun 3, 2024 that will close this issue
Backmerge: #4734 - Preview: Monomers from macro mode are not erased by Erase tool in micro mode #4737
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4734 - Preview: Monomers from macro mode are not erased by Erase too…
4028956 
…l in micro mode

- unblocked monomers deletion in micro mode
@rrodionov91 rrodionov91 linked a pull request Jun 4, 2024 that will close this issue
#4734 - Preview: Monomers from macro mode are not erased by Erase tool in micro mode #4743
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4734 - Preview: Monomers from macro mode are not erased by Erase too…
024c6c1 
…l in micro mode (#4743)

- unblocked monomers deletion in micro mode
rrodionov91 added a commit that referenced this issue Jun 4, 2024
@rrodionov91
#4734 - Preview: Monomers from macro mode are not erased by Erase too…
4eb4266 
…l in micro mode (#4737)

- unblocked monomers deletion in micro mode
@Zhirnoff
Copy link
Collaborator Author

2024-06-10_16h15_54.mp4

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Macromolecules Priority: High
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.22.0-rc.3
1 participant
@Zhirnoff