Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When changing zoom level in macro mode, there is no percentage indication #4744

Closed
Zhirnoff opened this issue Jun 4, 2024 · 3 comments · Fixed by #4758 or #4759
Closed

When changing zoom level in macro mode, there is no percentage indication #4744

Zhirnoff opened this issue Jun 4, 2024 · 3 comments · Fixed by #4758 or #4759
Labels
bug Macromolecules Priority: Low UI unification Bucket: Issues that need to be fixed to aligne Macro UI to Micro one
Milestone
Ketcher 2.22.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 4, 2024 •
edited
Loading

Steps to Reproduce

  1. Switch to Macro mode
  2. Add any monomer on canvas
  3. Change zoom by buttons or hotkeys
  4. Switch to Micro mode and back to Macro
  5. Change zoom by buttons or hotkeys

Actual behavior
When changing zoom level in macro mode, there is no percentage indication

Expected behavior
When changing zoom level in macro mode, a percentage indication should be displayed like in Micro mode

Screenshots

2024-06-04_15h39_44

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.2]

Bug found during testing: #4701
@Zhirnoff Zhirnoff added bug Priority: Low Macromolecules UI unification Bucket: Issues that need to be fixed to aligne Macro UI to Micro one labels Jun 4, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.22.0-rc.3 milestone Jun 4, 2024
@rrodionov91
Copy link
Collaborator

rrodionov91 commented Jun 4, 2024 •
edited
Loading

Does not reproduce. Verified with @Zhirnoff

@rrodionov91 rrodionov91 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jun 4, 2024

Reproduced after switch between micro/macro mode

@Zhirnoff Zhirnoff reopened this Jun 4, 2024
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4744 - When changing zoom level in macro mode, there is no percentag…
02014ea 
…e indication

- fixed ZoomControls component subscription to ZoomTool instance
@rrodionov91 rrodionov91 linked a pull request Jun 5, 2024 that will close this issue
#4744 - When changing zoom level in macro mode, there is no percentage indication #4758
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4744 - When changing zoom level in macro mode, there is no percentag…
acea238 
…e indication

- fixed ZoomControls component subscription to ZoomTool instance
@rrodionov91 rrodionov91 linked a pull request Jun 5, 2024 that will close this issue
Backmerge: #4744 - When changing zoom level in macro mode, there is no percentage indication #4759
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4744 - When changing zoom level in macro mode, there is no percentag…
87a2ce7 
…e indication (#4758)

- fixed ZoomControls component subscription to ZoomTool instance
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4744 - When changing zoom level in macro mode, there is no percentag…
9cefbab 
…e indication (#4759)

- fixed ZoomControls component subscription to ZoomTool instance
@Zhirnoff
Copy link
Collaborator Author

2024-06-10_16h22_59

Tested. Bug fixed.
Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.3]
Indigo version
[Version 1.21.0-rc.1]

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Macromolecules Priority: Low UI unification Bucket: Issues that need to be fixed to aligne Macro UI to Micro one
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.22.0-rc.3
2 participants
@rrodionov91 @Zhirnoff