Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is impossible to apply R-group to atom with attachment point attached #4773

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4855
Closed

It is impossible to apply R-group to atom with attachment point attached #4773

AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4855
Assignees
@Guch1g0v
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Milestone
Ketcher 2.23.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: It is impossible to apply R-group to atom with attachment point attached.zip
    OR manually create following configuration on the canvas:
    image
  2. Select R-Group label tool
    image
  3. Click on atom R1 attachment point connected to
    image

Actual behavior
System rises Edit Abbreviation dialog but it doesn't work - it is not possible to add atom to r-group in any option (Remove Abbreviation or Exit) selected
image

Expected behavior

  1. System shouldn't open Edit Abbreviation dialog
  2. R-group selection dialog should appear (and it should be possible to set r-group)
    image

As per requirements:

What happens if I apply R-Group on AP label?
No, since AP is not an atom - its a label connected to atom by bond (we can do that with atom AP label connected to)

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 6, 2024
@AlexeyGirin AlexeyGirin added the Micromolecules canvas Bucket: Micromolecules canvas related issues label Jun 6, 2024
Guch1g0v added a commit that referenced this issue Jun 17, 2024
@Guch1g0v
#4773 - It is impossible to apply R-group to atom with attachment poi…
87b19df 
…nt attached
@Guch1g0v Guch1g0v linked a pull request Jun 17, 2024 that will close this issue
#4773 - It is impossible to apply R-group to atom with attachment point attached #4855
Merged
9 tasks
@Guch1g0v Guch1g0v self-assigned this Jun 17, 2024
svvald pushed a commit that referenced this issue Jun 21, 2024
@Guch1g0v
#4773 - It is impossible to apply R-group to atom with attachment poi…
7ab4107 
…nt attached (#4855)

* #4773 - It is impossible to apply R-group to atom with attachment point attached

* hotfix: add logic for charge tool
@AnnaKosol
Copy link
Contributor

Verified

2024-07-02.14.52.02.mov

Versions:
Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 09:03:38
Indigo Version 1.21.0-rc.1.0-g9194599b2-x86_64-linux-gnu-11.2.1
MacOs Sonoma version 14.5
Chrome Version 126.0.6478.127 (Официальная сборка), (arm64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Projects
None yet
Milestone
Ketcher 2.23.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4773 - It is impossible to apply R-group to atom with attachment point attached epam/ketcher
3 participants
@AlexeyGirin @Guch1g0v @AnnaKosol