Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove monomers from the library (Peptides and CHEMs) #4780

Closed
5 tasks done
ljubica-milovic opened this issue Jun 6, 2024 · 3 comments · Fixed by #5178
Closed
5 tasks done

Remove monomers from the library (Peptides and CHEMs) #4780

ljubica-milovic opened this issue Jun 6, 2024 · 3 comments · Fixed by #5178
Assignees
@ljubica-milovic
Labels
feature request Monomer Library Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jun 6, 2024 •
edited by AlexeyGirin
Loading

Remove following peptides and CHEMs from the library:

  • Glp, pyroglutamic acid
  • Hyl5xi, (2S)-2-6-diamino-5-hydorxyhexanoic acid
  • Hiv, 2-hydroxyisovaleric acid
  • Maa, mercaptoacetic acid
  • Nty, nitrotyrosine
@ljubica-milovic ljubica-milovic changed the title Monomers to be removed (priority: high) (IN PROGRESS) Monomers to be removed Jun 14, 2024
@ljubica-milovic ljubica-milovic changed the title Monomers to be removed Remove monomers form the library Jul 17, 2024
@ljubica-milovic ljubica-milovic changed the title Remove monomers form the library Remove monomers form the library (Peptides and CHEMs) Jul 24, 2024
@ljubica-milovic ljubica-milovic self-assigned this Jul 24, 2024
@rrodionov91 rrodionov91 changed the title Remove monomers form the library (Peptides and CHEMs) Remove monomers from the library (Peptides and CHEMs) Jul 26, 2024
rrodionov91 added a commit that referenced this issue Jul 26, 2024
@rrodionov91
#4780 - Remove monomers form the library (Peptides and CHEMs)
e89120e 
#4781 - Change names of monomers (Peptides and CHEMs)

#5166 - Change symbols of monomers (Peptides and CHEMs)

#4787 - Change structure of monomers (Peptides and CHEMs)

#5167 - Change natural analogue of monomers Peptides and CHEMs)
@rrodionov91 rrodionov91 mentioned this issue Jul 26, 2024
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Jul 26, 2024 that will close this issue
#4780 - Remove monomers form the library (Peptides and CHEMs) #5178
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4780 - Remove monomers form the library (Peptides and CHEMs)
d6527c4 
#4781 - Change names of monomers (Peptides and CHEMs)

#5166 - Change symbols of monomers (Peptides and CHEMs)

#4787 - Change structure of monomers (Peptides and CHEMs)

#5167 - Change natural analogue of monomers Peptides and CHEMs)
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4780 - Remove monomers form the library (Peptides and CHEMs)
b7e6703 
#4781 - Change names of monomers (Peptides and CHEMs)

#5166 - Change symbols of monomers (Peptides and CHEMs)

#4787 - Change structure of monomers (Peptides and CHEMs)

#5167 - Change natural analogue of monomers Peptides and CHEMs)
rrodionov91 added a commit that referenced this issue Jul 29, 2024
@rrodionov91
#4780 - Remove monomers form the library (Peptides and CHEMs) (#5178)
4e504c5 
#4780 - Remove monomers form the library (Peptides and CHEMs)
#4781 - Change names of monomers (Peptides and CHEMs)
#5166 - Change symbols of monomers (Peptides and CHEMs)
#4787 - Change structure of monomers (Peptides and CHEMs)
#5167 - Change natural analogue of monomers Peptides and CHEMs)

- fixed tests and updated screenshots
- updated screenshots
@AlexeyGirin
Copy link
Collaborator

No test cases needed in that particular case

@AlexeyGirin AlexeyGirin mentioned this issue Jul 31, 2024
Closed
1 task
@AlexeyGirin
Copy link
Collaborator

Fixed.

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jul 31, 2024
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that particular case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljubica-milovic ljubica-milovic

Labels
feature request Monomer Library Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4780 - Remove monomers form the library (Peptides and CHEMs) epam/ketcher
2 participants
@AlexeyGirin @ljubica-milovic