Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to attach bond to attachment point label #4782

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4835
Closed

It is possible to attach bond to attachment point label #4782

AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4835
Assignees
@Guch1g0v
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Milestone
Ketcher 2.23.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: It is impossible to apply R-group to atom with attachment point attached.zip
    OR manually create following configuration on the canvas:
    image
  2. Select any bond tool (single bond in my case)
    image
  3. Click on attachment point R1 label
    image

Actual behavior
System attaches bond to label
image

Expected behavior
Nothing happens

As per requirements:

Can I bond AP with bond? (i.e. attach bond to AP)
No, since AP is not an atom - its a label connected to atom by bond (we can do that with atom AP label connected to)

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added bug Priority: Medium Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 6, 2024
@AlexeyGirin AlexeyGirin changed the title it is possible to attach bond to attachment point label It is possible to attach bond to attachment point label Jun 6, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 12, 2024
Guch1g0v added a commit that referenced this issue Jun 13, 2024
@Guch1g0v
#4782 - It is possible to attach bond to attachment point label
9d0d566
@Guch1g0v Guch1g0v linked a pull request Jun 13, 2024 that will close this issue
#4782 - It is possible to attach bond to attachment point label #4835
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jun 17, 2024
@Guch1g0v
#4782 - It is possible to attach bond to attachment point label (#4835)
2db467e
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Projects
None yet
Milestone
Ketcher 2.23.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4782 - It is possible to attach bond to attachment point label epam/ketcher
2 participants
@AlexeyGirin @Guch1g0v