Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System saves selection states of attachment point labels to KET file (it should not) #4791

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4832
Closed

System saves selection states of attachment point labels to KET file (it should not) #4791

AlexeyGirin opened this issue Jun 6, 2024 · 1 comment · Fixed by #4832
Assignees
@Guch1g0v
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Milestone
Ketcher 2.23.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 6, 2024 •
edited by Zhirnoff
Loading

Steps to Reproduce

  1. Load from file: System saves selection states of attachment point labels to KET file (it should not).zip
    OR manually create following configuration on the canvas:
    image
  2. Select one or few attachment points
    image
  3. Save canvas to KET file
  4. Load it back using New project way

Actual behavior
System adds R9 labeled attachment point
image

Expected behavior
System recovers selection state of attachment point labels. It should not.

2024-07-03_10h44_28

As per requirements:

Selection logic? Partial selection? Should selection be saved in KET?
Selection should work the same as for atoms but without saving selection state in KET file

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530
@AlexeyGirin AlexeyGirin added bug Priority: Low Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 6, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 11, 2024
Guch1g0v added a commit that referenced this issue Jun 12, 2024
@Guch1g0v
#4791 - System saves selection states of attachment point labels to K…
7c5b061 
…ET file (it should not)
@Guch1g0v Guch1g0v linked a pull request Jun 12, 2024 that will close this issue
#4791 - System saves selection states of attachment point labels to KET file (it should not) #4832
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jun 18, 2024
@Guch1g0v
#4791 - System saves selection states of attachment point labels to K…
73aadfb 
…ET file (it should not) (#4832)
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 3, 2024

Tested. Bug fixed.
2024-07-03_10h44_28

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.1]
Indigo version
[Version 1.22.0-rc.1]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Projects
None yet
Milestone
Ketcher 2.23.0-rc.1
3 participants
@AlexeyGirin @Zhirnoff @Guch1g0v