Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is allowed to change bond type between micro and macro #4806

Closed
AlexeyGirin opened this issue Jun 6, 2024 · 3 comments · Fixed by #4883 or #5191
Closed

It is allowed to change bond type between micro and macro #4806

AlexeyGirin opened this issue Jun 6, 2024 · 3 comments · Fixed by #4883 or #5191
Assignees
Labels
Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Load from file: We can change bond type between micro and macro.zip
    OR manually create following configuration on the canvas:
    image
  2. Open context menu for bond between micro and macro
    image
  3. Select any bond type except single one

Actual behavior
System changes bond type to selected
image

Expected behavior
It should be not allowed to change bond type between micro and macro

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Issue found while testing #4530

@AlexeyGirin AlexeyGirin added bug Priority: Medium Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 6, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 6, 2024
svvald pushed a commit that referenced this issue Jul 17, 2024
* fix:4806-it-is-allowed-to-change-bond-type-between-micro-and-macro

* feat: refactor isDisabled assigment for code optimization
@AlexeyGirin
Copy link
Collaborator Author

Not fully fixed.
It is possible to change bond type via Bond properties edit
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

@KristinaKasyanovskaya
Copy link
Collaborator

Fix #5191

Not fully fixed. It is possible to change bond type via Bond properties edit image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-25; 05:30:25
  • Indigo Toolkit Version 1.23.0-dev.1.14-g284c33a1-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.73 (Official Build) (64-bit)

rrodionov91 pushed a commit that referenced this issue Jul 31, 2024
@rrodionov91 rrodionov91 linked a pull request Jul 31, 2024 that will close this issue
11 tasks
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 7, 2024

Tested. Bug fixed.

2024-08-07_14h00_38

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.24.0-rc.1]
Indigo version
[Version 1.23.0-rc.1]

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment