Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering multiple ketcher editors on a page without an iframe #4833

Closed
ihuang8 opened this issue Jun 12, 2024 · 1 comment · Fixed by #4834
Closed

Support rendering multiple ketcher editors on a page without an iframe #4833

ihuang8 opened this issue Jun 12, 2024 · 1 comment · Fixed by #4834

Comments

@ihuang8
Copy link
Contributor

ihuang8 commented Jun 12, 2024

Background
Add the ability to render multiple ketcher editors on a page without an iframe. The iframe makes it more difficult to access the ketcher instance (e.g. #3693).

Solution

Instead of binding the ketcher instance to the window of an iframe, each instance could be stored in the React state instead.

@rrodionov91 rrodionov91 self-assigned this Jun 19, 2024
rrodionov91 pushed a commit that referenced this issue Jun 19, 2024
…an iframe (#4834)

* show multiple chemical structure editors in the same window
* use default init name

---------

Co-authored-by: Iris <iris@uncountable.com>
@rrodionov91 rrodionov91 added this to the Ketcher 2.23.0-rc.1 milestone Jun 19, 2024
@AlexeyGirin
Copy link
Collaborator

Impossible to verify since it require non-trivial development of Demo app
Will be done in the context of #4145

@github-project-automation github-project-automation bot moved this to Ready for testing in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for testing
Development

Successfully merging a pull request may close this issue.

3 participants