Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System loses connections to molecule R2 if there is no R1 attachment point #4839

Closed
rrodionov91 opened this issue Jun 13, 2024 · 1 comment · Fixed by #4841, #4843 or #4847
Closed

System loses connections to molecule R2 if there is no R1 attachment point #4839

rrodionov91 opened this issue Jun 13, 2024 · 1 comment · Fixed by #4841, #4843 or #4847
Assignees
@rrodionov91
Labels
Priority: High
Milestone
Ketcher 2.22.0-rc.6

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode
  2. Open file connection-issue.ket.zip or create molecule with R2 only attachment point and connect it to monomer, then save to file and open.

Actual behavior
System does not create connection between molecule and monomer.
image

Expected behavior
System creates connection between molecule and monomer.

Ketcher version [e.g. v2.4.2].
v2.22.0-rc.4
@rrodionov91 rrodionov91 added this to the Ketcher 2.22.0-rc.5 milestone Jun 13, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 13, 2024
rrodionov91 added a commit that referenced this issue Jun 13, 2024
@rrodionov91
#4839 - System loses connections to molecule R2 if there is no R1 att…
1e0adbd 
…achment point

- fixed attachment point number searching for molecules

#4836 - Molecule changes position after saving and opening from file
- added moving molecules structures in macromode for opening/pasting from file, snake layout

#4840 - Paste from clipboard does not work for molecules in macro mode
- changed serialization method in macromolecules paste
@rrodionov91 rrodionov91 mentioned this issue Jun 13, 2024
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Jun 13, 2024 that will close this issue
#4839 - System loses connections to molecule R2 if there is no R1 attachment point #4841
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 13, 2024
@rrodionov91
#4839 - System loses connections to molecule R2 if there is no R1 att…
65a557b 
…achment point

- fixed attachment point number searching for molecules

#4836 - Molecule changes position after saving and opening from file
- added moving molecules structures in macromode for opening/pasting from file, snake layout

#4840 - Paste from clipboard does not work for molecules in macro mode
- changed serialization method in macromolecules paste
rrodionov91 added a commit that referenced this issue Jun 13, 2024
@rrodionov91
Merge pull request #4841 from epam/4839-issue-molecule-to-monomer-con…
d30fb16 
…nection

* #4839 - System loses connections to molecule R2 if there is no R1 attachment point
- fixed attachment point number searching for molecules

#4836 - Molecule changes position after saving and opening from file
- added moving molecules structures in macromode for opening/pasting from file, snake layout

#4840 - Paste from clipboard does not work for molecules in macro mode
- changed serialization method in macromolecules paste

* - updated ketcher version to 2.22.0-rc.5
rrodionov91 added a commit that referenced this issue Jun 13, 2024
@rrodionov91
#4839 - System loses connections to molecule R2 if there is no R1 att…
389dea8 
…achment point
@rrodionov91 rrodionov91 linked a pull request Jun 13, 2024 that will close this issue
#4839 - System loses connections to molecule R2 if there is no R1 attachment point #4843
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 13, 2024
@rrodionov91
Merge pull request #4843 from epam/4839-lost-connection-molecule-monomer
b2288b5 
#4839 - System loses connections to molecule R2 if there is no R1 attachment point
@AlexeyGirin
Copy link
Collaborator

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.6 Build at 2024-06-13; 19:10:09
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

rrodionov91 added a commit that referenced this issue Jun 14, 2024
@rrodionov91
#4839 - System loses connections to molecule R2 if there is no R1 att…
6f09ae3 
…achment point

- fixed attachment point number searching for molecules

#4836 - Molecule changes position after saving and opening from file
- added moving molecules structures in macromode for opening/pasting from file, snake layout

#4840 - Paste from clipboard does not work for molecules in macro mode
- changed serialization method in macromolecules paste
rrodionov91 added a commit that referenced this issue Jun 14, 2024
@rrodionov91
#4839 - System loses connections to molecule R2 if there is no R1 att…
3704217 
…achment point
@rrodionov91 rrodionov91 linked a pull request Jun 14, 2024 that will close this issue
Backmerge: #4839 - System loses connections to molecule R2 if there is no R1 attachment point #4847
Merged
9 tasks
@rrodionov91 rrodionov91 mentioned this issue Jun 14, 2024
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 14, 2024
@rrodionov91
Backmerge: #4839 - System loses connections to molecule R2 if there i…
33fa525 
…s no R1 attachment point (#4847)

#4839 - System loses connections to molecule R2 if there is no R1 attachment point
- fixed attachment point number searching for molecules

#4836 - Molecule changes position after saving and opening from file
- added moving molecules structures in macromode for opening/pasting from file, snake layout

#4840 - Paste from clipboard does not work for molecules in macro mode
- changed serialization method in macromolecules paste
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Priority: High
Projects
None yet
Milestone
Ketcher 2.22.0-rc.6
2 participants
@rrodionov91 @AlexeyGirin