Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New approach and UI for switching between types in sequence mode #4872

Closed
ljubica-milovic opened this issue Jun 21, 2024 · 2 comments · Fixed by #5360
Closed

New approach and UI for switching between types in sequence mode #4872

ljubica-milovic opened this issue Jun 21, 2024 · 2 comments · Fixed by #5360
Assignees
@aproskurnov
Labels
feature request Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.25.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jun 21, 2024 •
edited
Loading

Background

Currently, if the user wants to switch a type in sequence mode they have to stop typing, click once to open the drop down menu, select from the menu, and then continue typing.

Solution

  1. Introduce keyboard commands for switching between types of typing:
    Ctrl+Alt+R switches to RNA type
    Ctrl+Alt+D switches to DNA type
    Ctrl+Alt+P switches to peptide type

On macOS instead of "Alt", "Option" is used.

  1. The current drop-down menu should be changed to:
    image
    2.1. When hovering over RNA the user should see "RNA (Ctrl+Alt+R)", when hovering over DNA the user should see "DNA (Ctrl+Alt+D)", when hovering over PEP the user should see "Peptides (Ctrl+Alt+P)".
    2.2. The default mode for typing is RNA.
@ljubica-milovic ljubica-milovic added draft feature request Sequence mode Bucket: Sequence mode related issues labels Jun 21, 2024
@ljubica-milovic ljubica-milovic added this to the Ketcher 2.24.0-rc.1 milestone Jun 24, 2024
@Zhirnoff Zhirnoff added the Test Cases Written Test cases has been written for that issue label Aug 13, 2024
@aproskurnov aproskurnov self-assigned this Aug 23, 2024
@rrodionov91 rrodionov91 linked a pull request Aug 27, 2024 that will close this issue
#4872 - New approach and UI for switching between types in sequence mode #5360
Merged
rrodionov91 pushed a commit that referenced this issue Sep 1, 2024
@aproskurnov
#4872 - New approach and UI for switching between types in sequence m…
016371f 
…ode (#5360)

Co-authored-by: Aleksei Proskurnov <aleksei_proskurnov@epam.com>
@AlexeyGirin
Copy link
Collaborator

Verified.
image
Ketcher - Version 2.24.0-rc.1 Build at 2024-09-02; 05:32:40
Version 1.24.0-dev.7.0-g59089022-wasm32-wasm-clang-12.0.0
Chrome 128.0.6613.114 (Official Build) (64-bit)
Win10

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Sep 4, 2024

Tested.
2024-09-04_18h02_27

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.25.0-rc.1]
Indigo version
[Version 1.24.0-rc.1]

@AlinaLysenko AlinaLysenko mentioned this issue Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aproskurnov aproskurnov

Labels
feature request Sequence mode Bucket: Sequence mode related issues Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.25.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4872 - New approach and UI for switching between types in sequence mode epam/ketcher
4 participants
@aproskurnov @AlexeyGirin @Zhirnoff @ljubica-milovic