Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Able to change attachment point label to an atom if it is selected first #4927

Closed
Zhirnoff opened this issue Jun 28, 2024 · 3 comments · Fixed by #4938, #4967 or #5019
Closed

Able to change attachment point label to an atom if it is selected first #4927

Zhirnoff opened this issue Jun 28, 2024 · 3 comments · Fixed by #4938, #4967 or #5019
Assignees
@Guch1g0v
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Milestone
Ketcher 2.23.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Add Benzene ring on canvas
  2. Add attachment point on Benzene ring by right-click menu
  3. Select with Rectangle selection R1 label
  4. Press on Nitrogen atom in atom toolbar

Actual behavior
Able to change attachment point label to an atom if it is selected first

Expected behavior
Unble to change attachment point label to an atom

Video

2024-06-28_18h48_25.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.22.0-rc.7]
Indigo version
[Version 1.21.0-rc.2]

Issue found while testing #4530
@Zhirnoff Zhirnoff added bug Priority: Medium Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 28, 2024
@Zhirnoff Zhirnoff added this to the Ketcher 2.23.0-rc.1 milestone Jun 28, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 29, 2024
Guch1g0v added a commit that referenced this issue Jun 29, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
344111d 
…ected first
@Guch1g0v Guch1g0v linked a pull request Jun 29, 2024 that will close this issue
#4927 - Able to change attachment point label to an atom if it is selected first #4938
Merged
9 tasks
svvald pushed a commit that referenced this issue Jul 1, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
c03a2e7 
…ected first (#4938)
@AnnaKosol
Copy link
Contributor

A modal window with information about the changes is displayed.

2024-07-02.13.00.24.mov

Versions:
Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 09:03:38
Indigo Version 1.21.0-rc.1.0-g9194599b2-x86_64-linux-gnu-11.2.1
MacOs Sonoma version 14.5
Chrome Version 126.0.6478.127 (Официальная сборка), (arm64)

@rrodionov91 rrodionov91 reopened this Jul 2, 2024
Guch1g0v added a commit that referenced this issue Jul 2, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
4649cbf 
…ected first - 2.23
@Guch1g0v Guch1g0v linked a pull request Jul 2, 2024 that will close this issue
#4927 - Able to change attachment point label to an atom if it is selected first #4967
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Jul 3, 2024

Moved to 2.23.0-rc.2 after discussion with developer @Guch1g0v because he has a pull request ready

accmeboot pushed a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
d907e24 
…ected first (#4938)
rrodionov91 pushed a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
8c99ec9 
…ected first - 2.23 (#4967)
Guch1g0v added a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
328feb8 
…ected first - 2.23 (#4967)
@Guch1g0v Guch1g0v linked a pull request Jul 5, 2024 that will close this issue
Backmerge: #4927 - Able to change attachment point label to an atom if it is selected first #5019
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jul 6, 2024
@Guch1g0v
#4927 - Able to change attachment point label to an atom if it is sel…
4f64813 
…ected first - 2.23 (#4967) (#5019)
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug fixed.

2024-07-11_15h05_27.mp4

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 124.0.6367.79 (Official Build) (64-bit)

Ketcher version
[Version 2.23.0-rc.2]
Indigo version
[Version 1.22.0-rc.2]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Medium
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
4 participants
@rrodionov91 @Zhirnoff @Guch1g0v @AnnaKosol