Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System allow to change atoms inside S-group without removing abbreviation #4929

Closed
AlexeyGirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #4944
Closed

System allow to change atoms inside S-group without removing abbreviation #4929

AlexeyGirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #4944
Assignees
@Guch1g0v
Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Milestone
Ketcher 2.23.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Load from file: System allow to change atoms inside S-group without removing abbreviation.zip
    OR manually create following configuration on the canvas:
    image
  2. Select atoms inside s-group (click on it)
    image
  3. Press N button in the right side tool bar
    image

Actual behavior
Atoms have been changed
image

Expected behavior
Remove abbreviation appears
image
(if user accepts - it applies proposed changes)

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Related issue: #4925
@AlexeyGirin AlexeyGirin added bug Priority: Low Micromolecules canvas Bucket: Micromolecules canvas related issues labels Jun 28, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.24.0-rc.1 milestone Jun 28, 2024
@Guch1g0v Guch1g0v self-assigned this Jun 30, 2024
Guch1g0v added a commit that referenced this issue Jun 30, 2024
@Guch1g0v
#4929 - System allow to change atoms inside S-group without removing …
691ef16 
…abbreviation
@Guch1g0v Guch1g0v linked a pull request Jun 30, 2024 that will close this issue
#4929 - System allow to change atoms inside S-group without removing abbreviation #4944
Merged
9 tasks
svvald pushed a commit that referenced this issue Jul 1, 2024
@Guch1g0v
#4929 - System allow to change atoms inside S-group without removing …
8e0159d 
…abbreviation (#4944)
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jul 3, 2024

Moved to 2.23.0-rc.2 after discussion with developer @Guch1g0v because he has a pull request ready

accmeboot pushed a commit that referenced this issue Jul 5, 2024
@Guch1g0v
#4929 - System allow to change atoms inside S-group without removing …
563b8eb 
…abbreviation (#4944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Guch1g0v Guch1g0v

Labels
bug Micromolecules canvas Bucket: Micromolecules canvas related issues Priority: Low
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
Development

Successfully merging a pull request may close this issue.

#4929 - System allow to change atoms inside S-group without removing abbreviation epam/ketcher
3 participants
@AlexeyGirin @Zhirnoff @Guch1g0v