Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Distance between unresolved monomer and preview tooltip is too large and it has no IDT alias #4947

Closed
AlexeyGirin opened this issue Jul 1, 2024 · 1 comment · Fixed by #5119
Closed

Preview: Distance between unresolved monomer and preview tooltip is too large and it has no IDT alias #4947

AlexeyGirin opened this issue Jul 1, 2024 · 1 comment · Fixed by #5119
Assignees
@KristinaKasyanovskaya
Labels
bug Priority: Low
Milestone
Ketcher 2.24.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 1, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load using paste from clipboard IDT type: /i2AmPr/
    image
  3. Hover mouse over appeared monomer

Actual behavior
System shows preview tooltip too above over the monomer and has no IDT alias
image

Expected behavior
System shows preview tooltip in the same distance as for other monomers and IDT alias inside
image

As per requirements:

2. Preview on hover should contain IDT alias only

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #4431
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jul 1, 2024
@AlexeyGirin AlexeyGirin changed the title Preview: Distance between unknown monomer and preview tooltip is too high and it has no IDT alias Preview: Distance between unknown monomer and preview tooltip is too large and it has no IDT alias Jul 1, 2024
@AlexeyGirin AlexeyGirin changed the title Preview: Distance between unknown monomer and preview tooltip is too large and it has no IDT alias Preview: Distance between unresolved monomer and preview tooltip is too large and it has no IDT alias Jul 1, 2024
@KristinaKasyanovskaya KristinaKasyanovskaya self-assigned this Jul 5, 2024
Merged
9 tasks
@KristinaKasyanovskaya KristinaKasyanovskaya linked a pull request Jul 16, 2024 that will close this issue
#4947 preview distance between unresolved monomer and preview tooltip is too large and it has no idt alias #5119
Merged
9 tasks
svvald pushed a commit that referenced this issue Jul 26, 2024
@KristinaKasyanovskaya
#4947 preview distance between unresolved monomer and preview tooltip…
c13bb49 
… is too large and it has no idt alias (#5119)

* feat: update open sistem connection dialog

* feat: add new logic with preview tooltip

* feat: change monomer name logic

* feat: change style for monomer name

* feat:add new logic for monomer connections
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
bug Priority: Low
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @KristinaKasyanovskaya