Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Strict mode #4979

Closed
AlekseiKhariukov opened this issue Jul 3, 2024 · 2 comments · Fixed by #5013
Closed

Support for Strict mode #4979

AlekseiKhariukov opened this issue Jul 3, 2024 · 2 comments · Fixed by #5013
Assignees
@accmeboot
Labels
feature request phase III Team G Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.24.0-rc.1

Comments

@AlekseiKhariukov
Copy link
Collaborator

Support for Strict mode
@accmeboot accmeboot self-assigned this Jul 4, 2024
accmeboot pushed a commit that referenced this issue Jul 5, 2024
#4979 - Support for Strict mode
88bac4d
accmeboot pushed a commit that referenced this issue Jul 5, 2024
#4979 - Support for Strict mode
45e257d
accmeboot pushed a commit that referenced this issue Jul 11, 2024
#4979 - Support for strict mode: remove keydown eventlistener
c9d3f12
accmeboot pushed a commit that referenced this issue Jul 11, 2024
#4979 - Support for strict mode: clean up
f632095
accmeboot pushed a commit that referenced this issue Jul 11, 2024
#4979 - Support for strict mode: adding mousedown remove listener func
3825331
accmeboot pushed a commit that referenced this issue Jul 12, 2024
#4979 - Support for strict mode: review fixes
bf0e4be
accmeboot pushed a commit that referenced this issue Jul 12, 2024
#4979 - Support for strict mode: review fixes
80a1f5c
@accmeboot accmeboot linked a pull request Jul 12, 2024 that will close this issue
#4979 - Support for Strict mode #5013
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jul 12, 2024
@accmeboot
#4979 - Support for Strict mode (#5013)
cecc56f 
- fixed ketcher initialisation in react strict mode
- enabled react strict mode in example
- added keydown/mousedown remove listener functions

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
@AlexeyGirin AlexeyGirin added Team G Test Cases Written Test cases has been written for that issue labels Jul 25, 2024
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that issue

@AlexeyGirin
Copy link
Collaborator

Verified verbally.
Strict mode doesn't affect on the release version of application, only dev builds affected

  • Ketcher Version 2.24.0-rc.1 Build at 2024-08-06; 19:17:47
  • Indigo Toolkit Version 1.23.0-rc.1.0-g85f89b8f5-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)

@rrodionov91 rrodionov91 mentioned this issue Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@accmeboot accmeboot

Labels
feature request phase III Team G Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.24.0-rc.1
Development

Successfully merging a pull request may close this issue.

#4979 - Support for Strict mode epam/ketcher
3 participants
@accmeboot @AlexeyGirin @AlekseiKhariukov