Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for the "attachment point tool" don't update with changed pixel settings #4983

Closed
AlekseiKhariukov opened this issue Jul 3, 2024 · 4 comments · Fixed by #5506 or #5525
Closed

Comments

@AlekseiKhariukov
Copy link
Collaborator

AlekseiKhariukov commented Jul 3, 2024

T-shape attachment points created with the Attachment Point Tool (or loaded from an external file) do not respect 'Bond thickness' global setting and are always drawn with default thickness.

Steps to reproduce:

  1. Add a single bond and an attachment point to a drawing.
  2. Go to Settings->Bonds and change the 'Bond thickness' parameter (e.g. increase up to 6)
  3. See that line width of the single bond has been updated accordingly while line width of the attachment point remain the same.

image

'Bond thickness' setting should apply to attachment points, similarly to bonds.

(?) Related Indigo task - #2070

@AnnaKosol
Copy link
Contributor

Steps:

  1. create benzine ring with attachment points
    Image
  2. change Bond thickness to 0.2 cm
  3. click on Apply button

Actual result:
Image
attachment point isn't changed thickness

Expected result:
attachment point is changed thickness

@AnnaKosol
Copy link
Contributor

AnnaKosol commented Sep 18, 2024

Steps:

  1. create molecule with primary attachment point
    Снимок экрана 2024-09-18 в 15 29 47
  2. change setting Bond thickness to 0.2 px
  3. click on Apply button

Actual result:
primary attachment point isn't displayed
Снимок экрана 2024-09-18 в 15 34 16

Снимок экрана 2024-09-18 в 15 31 27

Expected result:
all parts of molecule are displayed regarding settings

Moved this problem to #5544 after discussing with @rrodionov91

@AnnaKosol AnnaKosol reopened this Sep 18, 2024
@AnnaKosol
Copy link
Contributor

Verified
Снимок экрана 2024-09-19 в 14 22 29

Environment
Ketcher Version 2.25.0-rc.1 Build at 2024-09-18; 05:33:09
Indigo Version 1.25.0-dev.1.19-ge314cdb7-wasm32-wasm-clang-12.0.0
Chrome 128.0.6613.138 (arm64)
MacOs 14.6

@AnnaKosol
Copy link
Contributor

Screenshot 2024-10-08 at 14 53 08

Verified - attachment point updates by thickness

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment