Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spliting molecule on pieces with attachment points of each cause crash when switching to Macro mode #5023

Open
AlexeyGirin opened this issue Jul 6, 2024 · 1 comment
Open

Spliting molecule on pieces with attachment points of each cause crash when switching to Macro mode #5023

AlexeyGirin opened this issue Jul 6, 2024 · 1 comment
Assignees
@matejaivosevic
Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Milestone
Refined Backlog

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Molecules mode
  2. Load from file: Spliting molecule on pieces with attachment points of each cause crash when switching to Macro mode.zip
    image
  3. Delete one atom to split molecule on two pieces
    image
    image
  4. Switch to Macromolecules mode

Actual behavior
System crashes to white screen
image
rc.test.lifescience.opensource.epam.com-1720276833048.log
rc.test.lifescience.opensource.epam.com-1720276829927.log

Expected behavior
No crash
image

Versions

  • Ketcher Version 2.23.0-rc.1 Build at 2024-07-02; 08:57:41
  • Indigo Toolkit Version 1.22.0-rc.1.0-g2bef0ce6c-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #4530
@AlexeyGirin AlexeyGirin added bug Macro-Micro Bucket: Macro-Micro View related issues labels Jul 6, 2024
@beisenova-aliya beisenova-aliya self-assigned this Jul 17, 2024
beisenova-aliya added a commit that referenced this issue Jul 19, 2024
@beisenova-aliya
#5023 fix crashing of spliting molecule on pieces with attachment points
b7e7c03
@beisenova-aliya beisenova-aliya mentioned this issue Jul 19, 2024
Merged
9 tasks
svvald pushed a commit that referenced this issue Jul 29, 2024
@beisenova-aliya
#5023-Spliting molecule on pieces with attachment points of each caus…
c2d471d 
…e crash when switching to Macro mode (#5137)

* #5023 fix crashing of spliting molecule on pieces with attachment points

* fix: change condition to set fragment id to monomer
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Aug 1, 2024 •
edited
Loading

Not fixed.
image

Structure remains in memory still as one molecule and one monomer but should be two molecules and on monomer
image

Versions

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin reopened this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matejaivosevic matejaivosevic

Labels
bug Macro-Micro Bucket: Macro-Micro View related issues Priority: High
Projects
None yet
Milestone
Refined Backlog
Development

No branches or pull requests
5 participants
@NataliaLoginova @rrodionov91 @AlexeyGirin @matejaivosevic @beisenova-aliya